Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database session duration #22501

Merged
merged 3 commits into from
May 16, 2024
Merged

Fix database session duration #22501

merged 3 commits into from
May 16, 2024

Conversation

br41nslug
Copy link
Member

I stumbled on this mistake while working on the race condition.

Scope

What's changed:

  • When creating a new database session (using mode: session) this will now use the SESSION_TOKEN_TTL duration instead of defaulting to the longer lived REFRESH_TOKEN_TTL.

Potential Risks / Drawbacks

  • None i can think of at the moment

Review Notes / Questions

  • I would like to lorem ipsum

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: c06dddd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@hanneskuettner hanneskuettner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, makes a ton of sense.

@paescuj paescuj merged commit 8609b4a into main May 16, 2024
4 checks passed
@paescuj paescuj deleted the fix-session-ttl branch May 16, 2024 15:07
.changeset/dry-carrots-sin.md Show resolved Hide resolved
@github-actions github-actions bot added this to the Next Release milestone May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants