Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix large and real numbers in search query #22345

Merged
merged 34 commits into from Apr 30, 2024

Conversation

hanneskuettner
Copy link
Contributor

@hanneskuettner hanneskuettner commented Apr 30, 2024

This is a continuation of #22205 (did some git anti-magic and accidentally auto-closed the PR 🪄 :octocat: )

Scope

Postgres and MSSQL have trouble when using numbers larger than the targeted column in where clauses, as such we need to guard those calls against too large and invalid numbers. Additionally Postgres doesn't play well with floating point numbers used in where clauses of integer type fields.

What's changed:

  • Added a database helper to handle large numbers in where clauses and prevent them from hitting the database if they are outside of the database type limits.

Potential Risks / Drawbacks

None

Review Notes / Questions


Fixes #17946

Copy link

changeset-bot bot commented Apr 30, 2024

⚠️ No Changeset found

Latest commit: 078683a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hanneskuettner hanneskuettner changed the title Fix large numbers in search query Fix large and real numbers in search query Apr 30, 2024
@br41nslug br41nslug self-requested a review April 30, 2024 12:02
@br41nslug br41nslug merged commit d10385d into main Apr 30, 2024
4 checks passed
@br41nslug br41nslug deleted the fix-17946-postgres-search-error branch April 30, 2024 15:22
@github-actions github-actions bot added this to the Next Release milestone Apr 30, 2024
br41nslug added a commit that referenced this pull request Apr 30, 2024
* Add changeset

* small update

---------

Co-authored-by: Brainslug <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Search error
2 participants