Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store schema in shared cache Fix logic regarding fetching one schema at a time #22245

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

u12206050
Copy link
Contributor

This adds the schema to the redis cache as well as fixes the lock logic surrounding fetching the schema.

Testing locally with redis server and pm2 to spawn multiple containers shows significant improvement.

Fixes: #22243

Fix logic regarding fetching one schema at a time
Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: b5bdde1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@u12206050
Copy link
Contributor Author

Here is an historic view of our production environment of how the various changes within the PR made an impact:

Screenshot 2024-04-19 at 08 13 30

This shows a 92.86% reduction in the average time to get the schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 Needs Triage
Development

Successfully merging this pull request may close these issues.

Containers getSchema throwing "hit infinite loop"
1 participant