Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Extensions env #22178

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

WIP: Extensions env #22178

wants to merge 4 commits into from

Conversation

licitdev
Copy link
Member

Scope

What's changed:

  • Add new EXTENSIONS_ENV_ALLOW_LIST env
  • Extensions to useExtensionsEnv instead of useEnv
  • Clean process.env
  • Add a flag for internal flow operations which has access to the default env

Potential Risks / Drawbacks

  • Potential breaking change for projects with extensions that need certain envs
    • Mitigated by allowing all envs by default?

Review Notes / Questions

  • PR is WIP
  • Whether to clean process.env in useEnv instead of in useExtensionsEnv?

Copy link

changeset-bot bot commented Apr 11, 2024

⚠️ No Changeset found

Latest commit: 6802913

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 Needs Triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant