Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert the complete original payload on error flow events #22174

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

ferdinandlocksoftwares
Copy link

Adding @kartor

Scope

What's changed:

  • Revert the original payload when using the 'request' or 'database' error flow events

Review Notes / Questions

  • I would like to add this one once again as this was removed since from version 10.3 as this very important and been using this since start

Fixes #21249

Copy link

changeset-bot bot commented Apr 11, 2024

⚠️ No Changeset found

Latest commit: 4947e68

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ferdinandlocksoftwares
Copy link
Author

ferdinandlocksoftwares commented Apr 11, 2024

@br41nslug can you help me on the check failed on unit test?

@paescuj
Copy link
Member

paescuj commented Apr 12, 2024

The errors (@directus/errors) do not currently intend to hold any data except for the message. We would need to come up with a structure for that before proceeding with this PR. That's also why this data has been removed in 7daa775 (part of #18797).
Not sure if this PR is the right place to discuss this, though.

cc @rijkvanzanten


For this PR in particular:

  • The unit tests (resp. the build) currently fail because the InvalidForeignKeyError doesn't accept a invalid field. So the error interface would have to be updated as well.
  • If we're going to add that error data back, we should do so in a consistent manner for all DB vendors (and probably for other errors besides InvalidForeignKeyError too) - see again 7daa775

@br41nslug br41nslug self-assigned this Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

Receive the original payload when using the 'request' or 'database' error flow events
3 participants