Clean-up code in useItem composable
#22113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
paescuj
force-pushed
the
clean-up-useitem
branch
from
69946a9
to
9f66c2e
Compare
paescuj
force-pushed
the
clean-up-useitem
branch
from
9f66c2e
to
396602d
Compare
paescuj
requested review from
a team,
rijkvanzanten and
licitdev
and removed request for
a team
hanneskuettner
approved these changes
Apr 24, 2024
Co-authored-by: Hannes Küttner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
The code in the
useItemwas a bit messy (structure,any/ non-null assertions, ...), what made it difficult to find one's way around.Potential Risks / Drawbacks
No logical changes have been made - only type fixes, code simplification and relocation.
Review Notes / Questions
@directus/types#22027, due to usage ofAlterationstype