Make SDK realtime composable compatible with React Native #22105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: fc3d4bb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
paescuj
requested review from
a team,
rijkvanzanten and
DanielBiegler
and removed request for
a team
br41nslug
requested changes
Apr 5, 2024
There was a problem hiding this comment.
I think you'll want to update line 233 of the realtime composable instead so the WebSocket constructor gets a string with just a single .toString() cast.
const ws = new client.globals.WebSocket(url.toString());Did a quick test with some of the most common websocket libraries (SockJs/WS/uWebSockets/BunWS) and looks like a string should not be an issue there 😄
Co-authored-by: Brainslug <[email protected]>
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
br41nslug
approved these changes
Apr 25, 2024
paescuj
commented
Apr 25, 2024
Co-authored-by: Pascal Jufer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Make the SDK
realtimecomposable compatible with the WebSocket implementation of React Native, which only acceptsstringfor theurlparameter.Potential Risks / Drawbacks
None
Review Notes / Questions
None
Fixes #22098