Fix filter validation for field functions #22060
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
TIL the JSON count filter is broken since v9.14.4 (🤯):
This roots back to the filter validation not accounting for field functions (
count(json_field)
). Fortunately, this was not an issue for functions on relations (count(...)
) or dates (year(...)
), since the allowed operators for the fields itself and corresponding functions overlap there.The filter validation has now been adjusted to properly check for:
count
on JSON field)integer
/_eq
forcount
function) when using functionsStill works for relations and dates:
Potential Risks / Drawbacks
None, only bug fixing
Review Notes / Questions
Can be tested via Data Studio or API: