Remove nested transactions

[rijkvanzanten]

Scope

What's changed:

When using knex.transaction() it will create a transaction, even if you're already in a parent transaction. This in turn causes issues in some database types that don't handle nested transactions, or mixing of DDL and transactions well, like CockroachDB.

Bug #21424 was caused by the CollectionsService starting a transaction, and using the FieldService which in turn uses the ItemsService to create the fields in the meta tables in another transaction. This nested transaction structure causes CRDB to panic.

As far as I'm aware, we're never utilizing nested transactions on purpose, so to prevent other unexpected issues in the future I replaced every runtime usage of knex.transaction() with a new transaction utility that'll reuse the existing transaction if we're already in a transaction.

Potential Risks / Drawbacks

• This change affects basically everything in the whole API, so it's a high risk change.

Review Notes / Questions

• The fix is intended for CockroachDB, so additional testing there would be nice.
• Seeing the high risk, additional usage testing is required.
• This might result in a performance improvement in some databases by reducing the number of simultaneous transactions.

---

Fix 1/2 for #21424

[changeset-bot]

🦋 Changeset detected

Latest commit: 4be2991

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
@directus/api	Patch
directus	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[br41nslug]

promises promises promises 😂