Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix styling issues with the related-values display #21854

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

formfcw
Copy link
Contributor

@formfcw formfcw commented Mar 14, 2024

Scope

What's changed:

  • changed vertical padding of v-list-items.block (+ .dense) to provide more space for the render-template
    • this prevents the render-template from cutting off the mouseover-background of the related-values display
    • this also affects thumbnails as they get larger
  • fix alignment and overlapping of related-values display within the render-template
  • made height and padding of v-list-item.block (+ .dense) more dynamic

Before:
issue

After:
fix

Potential Risks / Drawbacks

  • Could cause visual bugs on other parts of the app, even though I've tested many use cases
    • default and dense listing
    • m2m, m2a listings
    • table layout
    • title in the drawer

Review Notes / Questions

  • Feel free to change things

Fixes #21853
Potentially fixes #22160

Copy link

changeset-bot bot commented Mar 14, 2024

🦋 Changeset detected

Latest commit: 78f30f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

app/src/components/v-list-item.vue Outdated Show resolved Hide resolved
app/src/displays/related-values/related-values.vue Outdated Show resolved Hide resolved
app/src/displays/related-values/related-values.vue Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 Needs Triage
2 participants