Nested alias returning null #21826
Open
Nested alias returning null #21826
+276
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f5fb3a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Fixes #18802.
In some cases using aliases in nested fields will return
null, even if data is available. Problem is that inside the recursive functionparseFieldsthealiasfield on the query is overwritten.Take the following example:
Given a schema with this nested collections:
Complete example schema
{ "data": { "version": 1, "directus": "10.10.0", "vendor": "postgres", "collections": [ { "collection": "first_level_a", "meta": { "accountability": "all", "archive_app_filter": true, "archive_field": null, "archive_value": null, "collapse": "open", "collection": "first_level_a", "color": null, "display_template": null, "group": "root_collection", "hidden": false, "icon": null, "item_duplication_fields": null, "note": null, "preview_url": null, "singleton": false, "sort": 1, "sort_field": null, "translations": null, "unarchive_value": null, "versioning": false }, "schema": { "name": "first_level_a" } }, { "collection": "first_level_b", "meta": { "accountability": "all", "archive_app_filter": true, "archive_field": null, "archive_value": null, "collapse": "open", "collection": "first_level_b", "color": null, "display_template": null, "group": "root_collection", "hidden": false, "icon": null, "item_duplication_fields": null, "note": null, "preview_url": null, "singleton": false, "sort": 2, "sort_field": null, "translations": null, "unarchive_value": null, "versioning": false }, "schema": { "name": "first_level_b" } }, { "collection": "root_collection", "meta": { "accountability": "all", "archive_app_filter": true, "archive_field": null, "archive_value": null, "collapse": "open", "collection": "root_collection", "color": null, "display_template": null, "group": null, "hidden": false, "icon": null, "item_duplication_fields": null, "note": null, "preview_url": null, "singleton": false, "sort": 1, "sort_field": null, "translations": null, "unarchive_value": null, "versioning": false }, "schema": { "name": "root_collection" } }, { "collection": "second_level_a", "meta": { "accountability": "all", "archive_app_filter": true, "archive_field": null, "archive_value": null, "collapse": "open", "collection": "second_level_a", "color": null, "display_template": null, "group": "first_level_a", "hidden": false, "icon": null, "item_duplication_fields": null, "note": null, "preview_url": null, "singleton": false, "sort": 1, "sort_field": null, "translations": null, "unarchive_value": null, "versioning": false }, "schema": { "name": "second_level_a" } } ], "fields": [ { "collection": "first_level_a", "field": "id", "type": "integer", "meta": { "collection": "first_level_a", "conditions": null, "display": null, "display_options": null, "field": "id", "group": null, "hidden": true, "interface": null, "note": null, "options": null, "readonly": false, "required": false, "sort": 1, "special": null, "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "id", "table": "first_level_a", "data_type": "integer", "default_value": "nextval('first_level_a_id_seq'::regclass)", "max_length": null, "numeric_precision": 32, "numeric_scale": 0, "is_nullable": false, "is_unique": true, "is_primary_key": true, "is_generated": false, "generation_expression": null, "has_auto_increment": true, "foreign_key_table": null, "foreign_key_column": null } }, { "collection": "first_level_a", "field": "second_level_a", "type": "integer", "meta": { "collection": "first_level_a", "conditions": null, "display": null, "display_options": null, "field": "second_level_a", "group": null, "hidden": false, "interface": "select-dropdown-m2o", "note": null, "options": null, "readonly": false, "required": false, "sort": 2, "special": [ "m2o" ], "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "second_level_a", "table": "first_level_a", "data_type": "integer", "default_value": null, "max_length": null, "numeric_precision": 32, "numeric_scale": 0, "is_nullable": true, "is_unique": false, "is_primary_key": false, "is_generated": false, "generation_expression": null, "has_auto_increment": false, "foreign_key_table": "second_level_a", "foreign_key_column": "id" } }, { "collection": "first_level_b", "field": "id", "type": "integer", "meta": { "collection": "first_level_b", "conditions": null, "display": null, "display_options": null, "field": "id", "group": null, "hidden": true, "interface": null, "note": null, "options": null, "readonly": false, "required": false, "sort": 1, "special": null, "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "id", "table": "first_level_b", "data_type": "integer", "default_value": "nextval('first_level_b_id_seq'::regclass)", "max_length": null, "numeric_precision": 32, "numeric_scale": 0, "is_nullable": false, "is_unique": true, "is_primary_key": true, "is_generated": false, "generation_expression": null, "has_auto_increment": true, "foreign_key_table": null, "foreign_key_column": null } }, { "collection": "root_collection", "field": "id", "type": "integer", "meta": { "collection": "root_collection", "conditions": null, "display": null, "display_options": null, "field": "id", "group": null, "hidden": true, "interface": "input", "note": null, "options": null, "readonly": true, "required": false, "sort": 1, "special": null, "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "id", "table": "root_collection", "data_type": "integer", "default_value": "nextval('root_collection_id_seq'::regclass)", "max_length": null, "numeric_precision": 32, "numeric_scale": 0, "is_nullable": false, "is_unique": true, "is_primary_key": true, "is_generated": false, "generation_expression": null, "has_auto_increment": true, "foreign_key_table": null, "foreign_key_column": null } }, { "collection": "root_collection", "field": "first_level_b", "type": "integer", "meta": { "collection": "root_collection", "conditions": null, "display": null, "display_options": null, "field": "first_level_b", "group": null, "hidden": false, "interface": "select-dropdown-m2o", "note": null, "options": null, "readonly": false, "required": false, "sort": 3, "special": [ "m2o" ], "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "first_level_b", "table": "root_collection", "data_type": "integer", "default_value": null, "max_length": null, "numeric_precision": 32, "numeric_scale": 0, "is_nullable": true, "is_unique": false, "is_primary_key": false, "is_generated": false, "generation_expression": null, "has_auto_increment": false, "foreign_key_table": "first_level_b", "foreign_key_column": "id" } }, { "collection": "root_collection", "field": "first_level_a", "type": "integer", "meta": { "collection": "root_collection", "conditions": null, "display": null, "display_options": null, "field": "first_level_a", "group": null, "hidden": false, "interface": "select-dropdown-m2o", "note": null, "options": null, "readonly": false, "required": false, "sort": 2, "special": [ "m2o" ], "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "first_level_a", "table": "root_collection", "data_type": "integer", "default_value": null, "max_length": null, "numeric_precision": 32, "numeric_scale": 0, "is_nullable": true, "is_unique": false, "is_primary_key": false, "is_generated": false, "generation_expression": null, "has_auto_increment": false, "foreign_key_table": "first_level_a", "foreign_key_column": "id" } }, { "collection": "second_level_a", "field": "id", "type": "integer", "meta": { "collection": "second_level_a", "conditions": null, "display": null, "display_options": null, "field": "id", "group": null, "hidden": true, "interface": null, "note": null, "options": null, "readonly": false, "required": false, "sort": 1, "special": null, "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "id", "table": "second_level_a", "data_type": "integer", "default_value": "nextval('second_level_a_id_seq'::regclass)", "max_length": null, "numeric_precision": 32, "numeric_scale": 0, "is_nullable": false, "is_unique": true, "is_primary_key": true, "is_generated": false, "generation_expression": null, "has_auto_increment": true, "foreign_key_table": null, "foreign_key_column": null } }, { "collection": "second_level_a", "field": "field_to_alias", "type": "string", "meta": { "collection": "second_level_a", "conditions": null, "display": null, "display_options": null, "field": "field_to_alias", "group": null, "hidden": false, "interface": "input", "note": null, "options": null, "readonly": false, "required": false, "sort": 2, "special": null, "translations": null, "validation": null, "validation_message": null, "width": "full" }, "schema": { "name": "field_to_alias", "table": "second_level_a", "data_type": "character varying", "default_value": null, "max_length": 255, "numeric_precision": null, "numeric_scale": null, "is_nullable": true, "is_unique": false, "is_primary_key": false, "is_generated": false, "generation_expression": null, "has_auto_increment": false, "foreign_key_table": null, "foreign_key_column": null } } ], "relations": [ { "collection": "first_level_a", "field": "second_level_a", "related_collection": "second_level_a", "meta": { "junction_field": null, "many_collection": "first_level_a", "many_field": "second_level_a", "one_allowed_collections": null, "one_collection": "second_level_a", "one_collection_field": null, "one_deselect_action": "nullify", "one_field": null, "sort_field": null }, "schema": { "table": "first_level_a", "column": "second_level_a", "foreign_key_table": "second_level_a", "foreign_key_column": "id", "constraint_name": "first_level_a_second_level_a_foreign", "on_update": "NO ACTION", "on_delete": "SET NULL" } }, { "collection": "root_collection", "field": "first_level_b", "related_collection": "first_level_b", "meta": { "junction_field": null, "many_collection": "root_collection", "many_field": "first_level_b", "one_allowed_collections": null, "one_collection": "first_level_b", "one_collection_field": null, "one_deselect_action": "nullify", "one_field": null, "sort_field": null }, "schema": { "table": "root_collection", "column": "first_level_b", "foreign_key_table": "first_level_b", "foreign_key_column": "id", "constraint_name": "root_collection_first_level_b_foreign", "on_update": "NO ACTION", "on_delete": "SET NULL" } }, { "collection": "root_collection", "field": "first_level_a", "related_collection": "first_level_a", "meta": { "junction_field": null, "many_collection": "root_collection", "many_field": "first_level_a", "one_allowed_collections": null, "one_collection": "first_level_a", "one_collection_field": null, "one_deselect_action": "nullify", "one_field": null, "sort_field": null }, "schema": { "table": "root_collection", "column": "first_level_a", "foreign_key_table": "first_level_a", "foreign_key_column": "id", "constraint_name": "root_collection_first_level_a_foreign", "on_update": "NO ACTION", "on_delete": "SET NULL" } } ] } }When we run the following example code, we will end up with
firstLevelB = null, which is incorrect!It should return something like
firstLevelB = { id: 1 }.If we move the
firstLevelBin the query above thefirstLevelA, it will actually return the correct value. This is caused by the bug this PR tries to tackle.What's changed:
aliasinstead ofquery.aliasPotential Risks / Drawbacks
convertWildcardsfunction, so the changes are untested if those aren't tested in the blackbox testingReview Notes / Questions