Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphql: Subscribing EventEmitter Overflow Warning #21728

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Graphql: Subscribing EventEmitter Overflow Warning #21728

wants to merge 6 commits into from
+164 −21

Conversation

br41nslug
Copy link
Member

@br41nslug br41nslug commented Mar 6, 2024 •
edited

Fixes #21570

Scope

What's changed:

  • Replaced the old EventEmitter based AsyncGenerator for GQL Subscriptions
  • Removed top-level global variables

Potential Risks / Drawbacks

  • It could impact graphql subscriptions at scale

Review Notes / Questions

  • I would like to lorem ipsum

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2024 •
edited

⚠️ No Changeset found

Latest commit: 5cdfcd0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@br41nslug br41nslug requested review from a team, DanielBiegler and licitdev and removed request for a team March 19, 2024 15:27
@paescuj paescuj self-assigned this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanielBiegler DanielBiegler Awaiting requested review from DanielBiegler DanielBiegler was automatically assigned from directus/review

@licitdev licitdev Awaiting requested review from licitdev licitdev was automatically assigned from directus/review

@hanneskuettner hanneskuettner Awaiting requested review from hanneskuettner

At least 1 approving review is required to merge this pull request.

Assignees

@paescuj paescuj

Labels
🍰 Bug ⚠️ Enterprise
Projects
Software Roadmap
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Graphql: Subscribing to same event more than 10 times throws a warning
4 participants
@br41nslug @paescuj @rijkvanzanten @hanneskuettner