Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target parameter to Vector and Rotation #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertlong
Copy link

I noticed it's not possible to get the rotation/translation of a Collider without allocating a new Vector or Rotation object. Now you can provide an object that implements Vector or Rotation such as THREE.Vector3 or THREE.Quaternion and those methods will write values from the RawVector/RawRotation to the provided objects.

Also, I was having some issues getting set up to build the libraries so I haven't been able to test this yet.

I have wasm-pack and typedoc installed and the latest version of Rust. I'd like to be able to build the compat versions of the library and link them into my project to test.

@sebcrozet
Copy link
Member

Thank you for this PR! Adding these optional object arguments is a great idea.
Could you please rebase your work on the master branch? I merged a PR today that adds CI for ubuntu and macos.

You may take a look at what the CI does for building rapier and rapier-compat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants