Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selected div height and width change #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fastAsF
Copy link
Contributor

@fastAsF fastAsF commented Oct 10, 2019

Hi @dillionmegida ! This is a pr for the idea called "Individual resizing of the elements instead of a general size.". It is WIP, currently you can select a div by click on it and deselect if you click that div again. If you select a div you will see his with, height and margin on the controls component. You can change the values for the selected div. Maybe in the next commit I will hide the width, height controllers and only show if there is a selected div.

There is a lot of bug now and I will solve them later, I just want some feedback if you think this is a good solution. Also code generation not working right now, but I will fix it. If you have a better idea for this issue please contact me!

@dillionmegida dillionmegida marked this pull request as ready for review October 10, 2019 22:37
@dillionmegida
Copy link
Owner

Thank you so much for your contributions.
Your idea is nice. But take note, the two fields for specifying general width and height would be removed. There'd only be a default width and height when page is refreshed.
Also, please read through the code generation codes thoroughly.

Your contributions are highly apprecited.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants