Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect the eslint.disable config setting #524

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

woss
Copy link

@woss woss commented Sep 11, 2023

this fixes #281 and probably a few other things.

@woss woss requested a review from dilanx as a code owner September 11, 2023 09:46
@uguremirmustafa
Copy link

Any update here?

@dilanx
Copy link
Owner

dilanx commented Dec 29, 2023

I don't believe this would fix anything. Trying to disable the eslint plugin when it isn't found would also throw a craco error.

Does removing the eslint section from your craco config resolve the issue?

@philsherry
Copy link

@dilanx To answer the above question:

“Does removing the eslint section from your craco config resolve the issue?”

It didn’t for me.

I came looking and searched for all mentions of ESLintWebpackPlugin, only to find a closed Issue and this open PR. I realise this PR is fairly stale now, but I thought I'd at least offer an answer to the question.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

craco: *** Cannot find ESLint plugin (ESLintWebpackPlugin). ***
4 participants