Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken shell function #27

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

fixed broken shell function #27

wants to merge 8 commits into from

Conversation

jjaimealeman
Copy link

//cleans our dist directory in case things got deleted
//gulp.task('clean', function() {
// return shell.task([
// 'rm -rf dist'
// ]);
// });
gulp.task('clean', shell.task([
'rm -rf dist'
]));

//create folders using shell
// gulp.task('scaffold', function() {
// return shell.task([
// 'mkdir dist',
// 'mkdir dist/fonts',
// 'mkdir dist/images',
// 'mkdir dist/scripts',
// 'mkdir dist/styles'
// ]
// );
// });
gulp.task('scaffold', shell.task([
'mkdir dist',
'mkdir dist/fonts',
'mkdir dist/images',
'mkdir dist/scripts',
'mkdir dist/styles'
]));

ryanbenson and others added 6 commits December 15, 2015 11:28
That should only belong in the final build
I just made minor change, updating gulp components version. This helped me and runs tasks faster.
Updated components version
@ryanbenson
Copy link
Contributor

Thanks for sending this over :D I'll check it out today. It seems like a quick fix. I appreciate the help!

@ryanbenson
Copy link
Contributor

Thanks again for updating this for everyone :) This is probably my fault, but I can't merge in the develop branch for this repo, because I was using the develop branch to completely re-write this project. I'm not sure if that was the best place to put it, but Harvest 2.0 is going to be a pretty big shift from Harvest 1.0.

I could just replicate your changes myself, but I want to give you credit for the fix! Would you mind creating a new & fresh branch and putting your changes on there, then I can merge it in?

Also, you don't need to comment out the updated code, you can just replace it instead of keeping the outdated shell work in there :)

Thanks again,

Ryan

@jjaimealeman
Copy link
Author

jjaimealeman commented Sep 15, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants