Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix various static checks in CI #34

Merged
merged 6 commits into from
May 31, 2024
Merged

Fix various static checks in CI #34

merged 6 commits into from
May 31, 2024

Conversation

ndombroski
Copy link
Collaborator

@ndombroski ndombroski commented May 31, 2024 •
edited
Loading

Fixes a number of warnings in our CI. Namely,

  • go static checks
  • GitHub Actions using deprecated features
  • upgrade static-check to a version compatible with go 1.19.3

@ndombroski ndombroski changed the title Ndombroski/static checks Fix various static checks in CI May 31, 2024
@ndombroski ndombroski force-pushed the ndombroski/static-checks branch from 2491078 to df649ef Compare May 31, 2024 16:16
lazypower
lazypower approved these changes May 31, 2024
View reviewed changes
Copy link

@lazypower lazypower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Disclaimer: I did not check into all the version bumps, so if the data model has changed, etc. I am not completely aware of what limitations may be at play.

@ndombroski ndombroski merged commit fe607dc into main May 31, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lazypower lazypower lazypower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ndombroski @lazypower