Enable pylint rules 2 #503
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MizukiTemma
commented
Oct 24, 2023
MizukiTemma
commented
Oct 24, 2023
Comment on lines
+84
to
90
| with open(new_path, "rb") as file: | ||
| converted_audiofile = File(file=file, name=Path(new_path)) | ||
| converted_audiofile.name = Path(new_path).name | ||
| converted_audiofile.content_type = "audio/mpeg" | ||
| converted_audiofile.size = os.path.getsize(new_path) | ||
| os.remove(new_path) | ||
| return converted_audiofile |
There was a problem hiding this comment.
@timobrembeck
This was what I've tried. I guess it's the cause of seek of closed file that converted_audiofile cannot reffer the file after with block is left.
There was a problem hiding this comment.
Ah ok interesting, I had hoped that File() would already read the file contents.
I don't have time to have a closer look at this problem, but I'll revisit this later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR enables pylint rules that are globally deactivated now.
Proposed changes
Resolved issues
Fixes: (partially #499)