LUN-420: User vocabulary can be marked as favorite

[ztefanie]

This pull request belongs to an issue on our bugtracker.
You can find it there by looking for an issue with the key which is mentioned in the title of this pull request.
It starts with the keyword LUN.

@steffenkleinle @f1sh1918
When marking user-vocabulary as favorite, we have the problem, that we cannot just save the id, as this id is also an id of a lunes-standard vocab. Same problem for dicitionary, where we want to show user-vocabulary in the future. I thought about different solutions:

1. The one in this PR: For documents we save the type (lunes-standard, lunes-protected, or user-created)
2. We could save two array with id's to AsyncStorage (e.g. lunes-favorites and user-created-favorites), but I think this is not a good idea, as we need to know and check everywhere (e.g. in an exercise or in the dictionary) if the word that is marked as a favorite, is lunes-standard or user-created.
3. We could somehow modify the id, like "lunes-standard-421" and "user-created-5", but I think this es even worse, as it is hard to check, if value are valid and also hard to filter, e.g. all favorites, that are user-created and need different loading-handling.

I will go on implementing this feature, if you think my suggested solution is the one we want to use.

As these first changes have been approved, I finished this ticket.

• I also replaced manual document building in some tests, with the document-builder-helper we have.
• Renamed the routing for VocabularyDetail, as it was named "DictionaryDetail" previously, but was used in UserVocabulary and Favorites, too.
• Renamed VocabularyDetailScreen to VocabularyDetailExerciseScreen, as this naming was duplicated.

[ztefanie]

@steffenkleinle @f1sh1918 (see comment above, i think ping does not work in description)

[f1sh1918]

i'm fine with solution 1

[steffenkleinle]

Same for me, solution 1 works for me.

[steffenkleinle]

Tested on android, nice work!

[steffenkleinle]

I don't want to open the discussion on this place again but I really dislike the moving and renaming to/from route folders 🙈 Makes it very hard to review changes since only small changes at the same time with renaming lead to github showing the file as deleted and added. Still a fan of the integreat way of just putting everything in the same folder and just prefixing it with the route name if necessary.

[steffenkleinle]

Not really reviewed/compared to previous

[ztefanie]

Not having a folder structur is really bad practice, but I see your point though. I think it would make sense to put every route in a subfolder also it they do no have components yet.

[f1sh1918]

i agree with Steffi in this case. We may add a guideline for naming & structuring of components/routes and stick to them. Sure once you move it its a pain to review but after having a clear structure this shouldn't happen. I also support structures like baseComponents Text/Buttons/TextInput etc. I think finding components and routes in integreat is quite a pain

[steffenkleinle]

The favorite icon of protected vocabulary is not displayed as marked as favorite, also in details view, but displayed in the favorites list.

[steffenkleinle]

Is this done with this PR? https://issues.tuerantuer.org/browse/LUN-307

[ztefanie]

The favorite icon of protected vocabulary is not displayed as marked as favorite, also in details view, but displayed in the favorites list.

Was broken before. Can not be fixed by us, as the api-endpoint is missing the feature do return protected words. Already opend a ticket.

[ztefanie]

Is this done with this PR? https://issues.tuerantuer.org/browse/LUN-307

This was already done here: #307

[f1sh1918]

Works fine on ios nice work! Even i have problems with the image path on ios emulators. but on real devices it works fine