Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

983: Upgrade prettier #1014

Merged
merged 1 commit into from
Apr 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
"jest-transform-stub": "^2.0.0",
"metro-react-native-babel-preset": "0.72.3",
"patch-package": "^8.0.0",
"prettier": "^2.7.1",
"prettier": "^3.2.5",
"react-dom": "18.2.0",
"react-test-renderer": "18.2.0",
"ts-jest": "^29.1.2",
Expand Down
2 changes: 1 addition & 1 deletion src/components/ImageCarousel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ const ImageCarousel = ({ images, minimized = false }: ImageCarouselProps): React
!!currentIndex &&
allSize > 1 &&
imagesUrls.map((item, index) =>
index + 1 === currentIndex ? <ActiveDot key={item.url} /> : <Dot key={item.url} />
index + 1 === currentIndex ? <ActiveDot key={item.url} /> : <Dot key={item.url} />,
)}
</PaginationView>
)
Expand Down
2 changes: 1 addition & 1 deletion src/components/ListItem.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ const ListItem = ({
}
setPressInY(null)
},
[pressInY, updatePressed, onPress]
[pressInY, updatePressed, onPress],
)

const titleToRender =
Expand Down
4 changes: 2 additions & 2 deletions src/components/__tests__/CameraOverlay.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('CameraOverlay', () => {
const { getByTestId, queryByTestId, findByTestId } = render(
<CameraOverlay setVisible={setVisible}>
<Text>Children</Text>
</CameraOverlay>
</CameraOverlay>,
)
const closeIcon = await findByTestId('close-circle-icon-white')
expect(closeIcon).toBeDefined()
Expand All @@ -27,7 +27,7 @@ describe('CameraOverlay', () => {
const { findByTestId } = render(
<CameraOverlay setVisible={setVisible}>
<Text>Children</Text>
</CameraOverlay>
</CameraOverlay>,
)
const closeIcon = await findByTestId('close-circle-icon-white')
expect(closeIcon).toBeDefined()
Expand Down
6 changes: 3 additions & 3 deletions src/components/__tests__/CustomTextInput.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@ describe('CustomTextInput', () => {

it('should show placeholder text', () => {
const { getByPlaceholderText } = render(
<CustomTextInput value='' clearable placeholder='Test' onChangeText={onChangeText} />
<CustomTextInput value='' clearable placeholder='Test' onChangeText={onChangeText} />,
)
expect(getByPlaceholderText('Test')).toBeTruthy()
})

it('should not show clear indicator with empty input', () => {
const { queryByTestId } = render(
<CustomTextInput value='' clearable placeholder='Test' onChangeText={onChangeText} />
<CustomTextInput value='' clearable placeholder='Test' onChangeText={onChangeText} />,
)
expect(queryByTestId('clearInput')).toBeNull()
})

it('should show indicator when input was set', () => {
const { getByTestId } = render(
<CustomTextInput value='My Input' clearable placeholder='Test' onChangeText={onChangeText} />
<CustomTextInput value='My Input' clearable placeholder='Test' onChangeText={onChangeText} />,
)
expect(getByTestId('clearInput')).toBeTruthy()
})
Expand Down
2 changes: 1 addition & 1 deletion src/components/__tests__/ExerciseHeader.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ describe('ExerciseHeader', () => {
feedbackType={FeedbackType.vocabularyItem}
feedbackForId={1}
exerciseKey={ExerciseKeys.vocabularyList}
/>
/>,
)
expect(getByTestId('customModal')).toBeTruthy()
expect(getByTestId('customModal').props.visible).toBe(false)
Expand Down
2 changes: 1 addition & 1 deletion src/components/__tests__/FavoriteButton.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('FavoriteButton', () => {
render(
<NavigationContainer>
<FavoriteButton vocabularyItem={vocabularyItem} />
</NavigationContainer>
</NavigationContainer>,
)

it('should add favorite on click', async () => {
Expand Down
6 changes: 3 additions & 3 deletions src/components/__tests__/FeedbackModal.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('FeedbackModal', () => {

it('should have a disabled send button when message is empty', () => {
const { getByText, getByPlaceholderText } = render(
<FeedbackModal visible onClose={onClose} feedbackType={FeedbackType.vocabularyItem} feedbackForId={1} />
<FeedbackModal visible onClose={onClose} feedbackType={FeedbackType.vocabularyItem} feedbackForId={1} />,
)
expect(getByText(getLabels().feedback.sendFeedback)).toBeDisabled()
const feedbackInputField = getByPlaceholderText(getLabels().feedback.feedbackPlaceholder)
Expand All @@ -26,7 +26,7 @@ describe('FeedbackModal', () => {

it('should get a cleared feedback text when clear button was clicked', () => {
const { getByPlaceholderText, getByTestId } = render(
<FeedbackModal visible onClose={onClose} feedbackType={FeedbackType.vocabularyItem} feedbackForId={1} />
<FeedbackModal visible onClose={onClose} feedbackType={FeedbackType.vocabularyItem} feedbackForId={1} />,
)
const feedbackInputField = getByPlaceholderText(getLabels().feedback.feedbackPlaceholder)
fireEvent.changeText(feedbackInputField, 'Mein Feedback')
Expand All @@ -36,7 +36,7 @@ describe('FeedbackModal', () => {

it('should send feedback', () => {
const { getByText, getByPlaceholderText } = render(
<FeedbackModal visible onClose={onClose} feedbackType={FeedbackType.vocabularyItem} feedbackForId={1} />
<FeedbackModal visible onClose={onClose} feedbackType={FeedbackType.vocabularyItem} feedbackForId={1} />,
)
const feedbackInputField = getByPlaceholderText(getLabels().feedback.feedbackPlaceholder)
const emailInputField = getByPlaceholderText(getLabels().feedback.mailPlaceholder)
Expand Down
2 changes: 1 addition & 1 deletion src/components/__tests__/ListItem.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ describe('ListItem', () => {
badgeLabel={badge}
arrowDisabled={arrowDisabled}
disabled={disabled}
/>
/>,
)

it('should render texts', () => {
Expand Down
2 changes: 1 addition & 1 deletion src/components/__tests__/Loading.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe('Loading', () => {
render(
<Loading isLoading={isLoading}>
<Text>{childText}</Text>
</Loading>
</Loading>,
)

it('should not render children when isLoading is true', () => {
Expand Down
15 changes: 12 additions & 3 deletions src/components/__tests__/NotAuthorisedView.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,21 @@ describe('NotAuthorisedView', () => {

it('should render description', () => {
const { getByText } = render(
<NotAuthorisedView setVisible={setVisible} description={getLabels().general.camera.noAuthorization.description} />
<NotAuthorisedView
setVisible={setVisible}
description={getLabels().general.camera.noAuthorization.description}
/>,
)
const isNoAuthDescription = getByText(getLabels().general.camera.noAuthorization.description)
expect(isNoAuthDescription).toBeTruthy()
})

it('should successfully go back', () => {
const { getByText } = render(
<NotAuthorisedView setVisible={setVisible} description={getLabels().general.camera.noAuthorization.description} />
<NotAuthorisedView
setVisible={setVisible}
description={getLabels().general.camera.noAuthorization.description}
/>,
)
const buttonVisible = getByText(getLabels().general.back)
fireEvent.press(buttonVisible)
Expand All @@ -34,7 +40,10 @@ describe('NotAuthorisedView', () => {
it('should open settings successfully', () => {
mocked(Linking.openSettings).mockImplementationOnce(Promise.resolve)
const { getByText } = render(
<NotAuthorisedView setVisible={setVisible} description={getLabels().general.camera.noAuthorization.description} />
<NotAuthorisedView
setVisible={setVisible}
description={getLabels().general.camera.noAuthorization.description}
/>,
)
const message = getByText(getLabels().settings.settings)
fireEvent.press(message)
Expand Down
4 changes: 2 additions & 2 deletions src/components/__tests__/RouteWrapper.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('RouteWrapper', () => {
const { queryByTestId } = render(
<RouteWrapper bottomBackgroundColor={theme.colors.background}>
<div />
</RouteWrapper>
</RouteWrapper>,
)
expect(queryByTestId('hiddenContainer')).toBeDefined()
Platform.OS = platform
Expand All @@ -26,7 +26,7 @@ describe('RouteWrapper', () => {
const { queryByTestId } = render(
<RouteWrapper bottomBackgroundColor={theme.colors.background}>
<div />
</RouteWrapper>
</RouteWrapper>,
)
expect(queryByTestId('hiddenContainer')).toBeNull()
Platform.OS = platform
Expand Down
6 changes: 3 additions & 3 deletions src/components/__tests__/ServerResponseHandler.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('ServerResponseHandler', () => {
const { getByText } = render(
<ServerResponseHandler error={error} loading={false} refresh={refresh}>
TestContent
</ServerResponseHandler>
</ServerResponseHandler>,
)

expect(getByText(error.message)).toBeTruthy()
Expand All @@ -26,7 +26,7 @@ describe('ServerResponseHandler', () => {
const { getByTestId } = render(
<ServerResponseHandler error={null} loading refresh={refresh}>
TestContent
</ServerResponseHandler>
</ServerResponseHandler>,
)

expect(getByTestId('loading')).toBeTruthy()
Expand All @@ -36,7 +36,7 @@ describe('ServerResponseHandler', () => {
const { getByText } = render(
<ServerResponseHandler error={null} loading={false} refresh={refresh}>
<Text>TestContent</Text>
</ServerResponseHandler>
</ServerResponseHandler>,
)

expect(getByText('TestContent')).toBeTruthy()
Expand Down
4 changes: 2 additions & 2 deletions src/components/__tests__/VocabularyList.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ describe('VocabularyList', () => {
mockUseLoadAsyncWithData(vocabularyItems)

const { getByText, getAllByText, getAllByTestId } = render(
<VocabularyList title='Title' vocabularyItems={vocabularyItems} onItemPress={onItemPress} />
<VocabularyList title='Title' vocabularyItems={vocabularyItems} onItemPress={onItemPress} />,
)

expect(getByText('Title')).toBeTruthy()
Expand All @@ -43,7 +43,7 @@ describe('VocabularyList', () => {

it('should call onItemPress with correct index', () => {
const { getByText } = render(
<VocabularyList title='Title' vocabularyItems={vocabularyItems} onItemPress={onItemPress} />
<VocabularyList title='Title' vocabularyItems={vocabularyItems} onItemPress={onItemPress} />,
)

expect(onItemPress).toHaveBeenCalledTimes(0)
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export type ServerResponseDiscipline = {

export const formatDiscipline = (
item: ServerResponseDiscipline,
loadingInfo: DisciplinesRequestParams
loadingInfo: DisciplinesRequestParams,
): Discipline => ({
...item,
numberOfChildren: item.total_discipline_children || item.total_training_sets || item.total_documents,
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useLoadAsync.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const loadAsync = async <T, P>(
params: P,
setData: (data: T | null) => void,
setError: (error: Error | null) => void,
setLoading: (loading: boolean) => void
setLoading: (loading: boolean) => void,
): Promise<void> => {
setLoading(true)

Expand Down
4 changes: 2 additions & 2 deletions src/hooks/useLoadVocabularyItems.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export type VocabularyItemFromServer = {

export const formatVocabularyItemFromServer = (
vocabularyItemFromServer: VocabularyItemFromServer,
apiKey?: string
apiKey?: string,
): VocabularyItem => ({
id: vocabularyItemFromServer.id,
word: vocabularyItemFromServer.word,
Expand All @@ -36,7 +36,7 @@ export const formatVocabularyItemFromServer = (

export const formatVocabularyItemsFromServer = (
vocabularyItemFromServers: VocabularyItemFromServer[],
apiKey?: string
apiKey?: string,
): VocabularyItem[] => vocabularyItemFromServers.map(item => formatVocabularyItemFromServer(item, apiKey))

export const loadVocabularyItems = async ({
Expand Down
2 changes: 1 addition & 1 deletion src/navigation/BottomTabNavigator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ const BottomTabNavigator = (): JSX.Element | null => {
const { data: isDevMode } = useLoadAsync(getDevMode, null)
const { data: numberOfWordsNeedingRepetition, refresh: refreshRepetitionBadge } = useLoadAsync(
RepetitionService.getNumberOfWordsNeedingRepetitionWithUpperBound,
undefined
undefined,
)

useFocusEffect(refreshRepetitionBadge)
Expand Down
4 changes: 2 additions & 2 deletions src/routes/__tests__/OverlayMenuScreen.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('OverlayMenu', () => {
const { getByTestId } = renderWithTheme(
<NavigationContainer>
<OverlayMenu navigation={navigation} />
</NavigationContainer>
</NavigationContainer>,
)
const close = getByTestId('close-icon-white')
expect(close).toBeTruthy()
Expand All @@ -31,7 +31,7 @@ describe('OverlayMenu', () => {
const { getByText } = renderWithTheme(
<NavigationContainer>
<OverlayMenu navigation={navigation} />
</NavigationContainer>
</NavigationContainer>,
)

const item = getByText(menuItem)
Expand Down
4 changes: 2 additions & 2 deletions src/routes/__tests__/ProfessionSelectionScreen.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('ProfessionSelectionScreen', () => {
mocked(useReadSelectedProfessions).mockReturnValueOnce(getReturnOf(null))

const { findByText, queryAllByTestId } = render(
<ProfessionSelectionScreen route={getRoute()} navigation={navigation} />
<ProfessionSelectionScreen route={getRoute()} navigation={navigation} />,
)
expect(await findByText(getLabels().scopeSelection.skipSelection)).toBeDefined()
const profession = await findByText(mockDisciplines()[0].title)
Expand All @@ -56,7 +56,7 @@ describe('ProfessionSelectionScreen', () => {
mocked(useReadSelectedProfessions).mockReturnValueOnce(getReturnOf([mockDisciplines()[0].id]))

const { findByText, queryAllByTestId } = render(
<ProfessionSelectionScreen route={getRoute()} navigation={navigation} />
<ProfessionSelectionScreen route={getRoute()} navigation={navigation} />,
)
expect(await findByText(getLabels().scopeSelection.confirmSelection)).toBeDefined()
const profession = await findByText(mockDisciplines()[0].title)
Expand Down
2 changes: 1 addition & 1 deletion src/routes/__tests__/VocabularyListScreen.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ describe('VocabularyListScreen', () => {
mockUseLoadAsyncWithData(vocabularyItems)

const { getByText, getAllByText, getAllByTestId } = render(
<VocabularyListScreen route={route} navigation={navigation} />
<VocabularyListScreen route={route} navigation={navigation} />,
)

expect(getByText(getLabels().exercises.vocabularyList.title)).toBeTruthy()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const AddCustomDiscipline = ({ navigation }: AddCustomDisciplineScreenProps): JS
setErrorMessage(
error.response?.status === HTTP_STATUS_CODE_FORBIDDEN
? getLabels().addCustomDiscipline.error.wrongCode
: getLabels().addCustomDiscipline.error.technical
: getLabels().addCustomDiscipline.error.technical,
)
})
.finally(() => setLoading(false))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ describe('AddCustomDisciplineScreen', () => {
const submitButton = await findByText(getLabels().addCustomDiscipline.submitLabel)
fireEvent.press(submitButton)
await waitFor(() =>
expect(RNAsyncStorage.setItem).toHaveBeenCalledWith('customDisciplines', '["test","another_test_discipline"]')
expect(RNAsyncStorage.setItem).toHaveBeenCalledWith('customDisciplines', '["test","another_test_discipline"]'),
)
await waitFor(() => expect(navigation.goBack).toHaveBeenCalled())
})
Expand All @@ -63,7 +63,7 @@ describe('AddCustomDisciplineScreen', () => {

it('should show wrong-code-error', async () => {
const { findByText, getByText, findByPlaceholderText } = render(
<AddCustomDisciplineScreen navigation={navigation} />
<AddCustomDisciplineScreen navigation={navigation} />,
)
mocked(loadDiscipline).mockRejectedValueOnce({ response: { status: 403 } })
const textField = await findByPlaceholderText(getLabels().addCustomDiscipline.placeholder)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const ArticleChoiceExerciseScreen = ({ navigation, route }: ArticleChoiceExercis
const answerOptions = ARTICLES.filter(it => it.id !== 0 && it.id !== 4)

const singularVocabularyItems = vocabularyItems.filter(it =>
answerOptions.some(answerOption => JSON.stringify(it.article) === JSON.stringify(answerOption))
answerOptions.some(answerOption => JSON.stringify(it.article) === JSON.stringify(answerOption)),
)

const vocabularyItemToAnswers = (vocabularyItem: VocabularyItem): Answer[] =>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ describe('ArticleChoiceExerciseScreen', () => {

it('should not allow to skip last vocabularyItem', () => {
const { queryByText, getByText, getAllByText } = render(
<ArticleChoiceExerciseScreen route={route} navigation={navigation} />
<ArticleChoiceExerciseScreen route={route} navigation={navigation} />,
)

expect(getAllByText(/Spachtel/)).toHaveLength(3)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const ChoiceExerciseScreen = ({
const [currentWord, setCurrentWord] = useState<number>(0)
const [selectedAnswer, setSelectedAnswer] = useState<Answer | null>(null)
const [results, setResults] = useState<VocabularyItemResult[]>(
shuffleArray(vocabularyItems.map(vocabularyItem => ({ vocabularyItem, result: null, numberOfTries: 0 })))
shuffleArray(vocabularyItems.map(vocabularyItem => ({ vocabularyItem, result: null, numberOfTries: 0 }))),
)
const { vocabularyItem, numberOfTries, result } = results[currentWord]
const [answers, setAnswers] = useState<Answer[]>(vocabularyItemToAnswer(vocabularyItem))
Expand All @@ -70,11 +70,11 @@ const ChoiceExerciseScreen = ({
if (vocabularyItems.length !== results.length || force) {
setCurrentWord(0)
setResults(
shuffleArray(vocabularyItems.map(vocabularyItem => ({ vocabularyItem, result: null, numberOfTries: 0 })))
shuffleArray(vocabularyItems.map(vocabularyItem => ({ vocabularyItem, result: null, numberOfTries: 0 }))),
)
}
},
[vocabularyItems, results]
[vocabularyItems, results],
)

useEffect(initializeExercise, [initializeExercise])
Expand All @@ -100,7 +100,7 @@ const ChoiceExerciseScreen = ({

const onExerciseCheated = async (result: SimpleResult): Promise<void> => {
await onExerciseFinished(
results.map(it => ({ ...it, numberOfTries: result === SIMPLE_RESULTS.correct ? 1 : numberOfMaxRetries, result }))
results.map(it => ({ ...it, numberOfTries: result === SIMPLE_RESULTS.correct ? 1 : numberOfMaxRetries, result })),
)
}

Expand Down
Loading