Remove x Locations/Events selected string for observer role
#3297
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MizukiTemma
approved these changes
Dec 17, 2024
lunars97
force-pushed
the
enhancement/remove-x-locations-and-events-selected-for-observer-role
branch
from
fb05fc7 to
83f2f38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Currently the strings
X Locations selectedandX Events selectedare being displayed regardless of user role. The observer role can not see checkboxes and therefore can not manupulate anything thus the stringsX Locations/Events selectedshould be hidden.Proposed changes
X Locations selectedin archived locations (currently it does not exist) and add check condition whether the user role allowed to see it or notSide effects
Resolved issues
Fixes: #3263
Pull Request Review Guidelines