Add filter for external calendar #3295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeyStk
requested review from
PeterNerlich,
charludo,
MizukiTemma and
jarlhengstmengel
Comment on lines
+162
to
+170
| if ( | ||
| calendar.EVENT_NOT_FROM_EXTERNAL_CALENDAR | ||
| in self.cleaned_data["imported_event"] | ||
| ): | ||
| events = events.filter(external_calendar__isnull=True) | ||
| elif ( | ||
| calendar.EVENT_FROM_EXTERNAL_CALENDAR in self.cleaned_data["imported_event"] | ||
| ): | ||
| events = events.filter(external_calendar__isnull=False) |
There was a problem hiding this comment.
That means the default behavior is that only non-imported events are shown, since both checkboxes are checkbed by default, but only the first case applies.
For me the expected behavior would be:
- Both checked: No filter applied
- One checked: Filter either for has external calendar or has no external calendar
- None checked: I guess this would be invalid and treated as both checked, like for the other checkboxes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds a filter for external calendars to the event list view. It only makes sense to merge this PR once we decide to "go live" with the external calendar feature.
Proposed changes
Side effects
None?
Resolved issues
Fixes: #3102
Pull Request Review Guidelines