Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text direction in form #3293

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

MizukiTemma
Copy link
Member

@MizukiTemma MizukiTemma commented Dec 13, 2024

Short description

This PR fixes text direction of the title and content field.

Proposed changes

  • Pass right_to_left in the event, POI and imprint view too, which is already used in the page form to set the text direction of TinyMCE.
  • Add text_direction in the event, POI, imprint and page view to set the text direction of title input field in the template.

Side effects

  • right_to_left and text_direction have almost the same function but I let both exist, because right_to_left is already being used in several places and it does not look cool (in my opinion) to write text_direction == "rtl" or something repeatedly 😅
  • If I remember correctly, there was once a discusion about fixing the text direction of title field but it was rejected/postponed due to some technical problem or complexity or something. Though I couldn't find such thema in the repository, it may be a wrong memory. If you remember or know such (potential) problem, please comment 👀

Resolved issues

Fixes: #3290


Pull Request Review Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MalteApp: The visualization of Urdu in CMS "Nachrichten" should be RTL
1 participant