Stop hiding the grids when POI is removed #3292
Conversation
MizukiTemma
added
deadline
There was a problem hiding this comment.
Thank you very much for the PR! I think it looks good so far 🚀
During my review I checked the following:
✔️ The PR follows the design and uses the correct wording of the design
✔️ Code is understandable to me (besides one nit and one question, see below :) )
✔️ Checking in the events form for side effects. By positive testing, I couldn't find a side effect. The next reviewer could focus on some negative testing :)
| @@ -3,11 +3,11 @@ import { getCsrfToken } from "./utils/csrf-token"; | |||
|
|
|||
There was a problem hiding this comment.
Nit: I think we said at one point, that the underscore should be used for Python/Django files and for JS/TS files, we just a dash instead. So, if I remember correctly, I think this should be poi-box.ts. I hope changing this won't give you a headache 🙈
| console.debug("Removed POI data"); | ||
| document.getElementById("poi-address-container").getElementsByTagName("input")[0].value = "-1"; |
There was a problem hiding this comment.
Am I understanding correctly that you're searching for the poi input field? If so, I think it would be better to get the Element by id, as it already has the id of poi-query-input. With the current implementation I see the potential risk, that we at one point in the future we add another input field and then this line would not be correct anymore?
There was a problem hiding this comment.
The target is another input element in _poi_address_container.html but it has an ID too and your suggestion is applied 😸
MizukiTemma
force-pushed
the
bug/fix_hiding_grids
branch
from
f0c5da6 to
b0c0dda
Compare
|
@JoeyStk Thank you for review 😸 Your suggetions are applied 👍 |
MizukiTemma
requested review from
charludo,
lunars97,
david-venhoff and
jarlhengstmengel
Short description
This PR fixes the prblem that the middle and right grid are closing when a POI is removed while editing an existing contact.
Proposed changes
Side effects
Resolved issues
Fixes: #3151
Pull Request Review Guidelines