Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cancel button to creation and edit forms #3251

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

lunars97
Copy link
Contributor

Short description

Add cancel button to create and update form where user can just go back to the list overview instead of going back through side menu navigation

Proposed changes

  • Add anchor tag with ghost-button style which returns to the list overview of the related forms

Side effects

  • should be none

Resolved issues

Fixes: #2930


Pull Request Review Guidelines

Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much!
This looks quite good already. I only have two thoughts:

  1. I think this deserves a release note
  2. I'm unsure about the page view at the moment. I think I would have put "Cancel" at to the far left, but maybe this is a question for @nikolahoff. Do you like it the way it is at the moment?
    grafik

@lunars97
Copy link
Contributor Author

Thank you very much! This looks quite good already. I only have two thoughts:

  1. I think this deserves a release note
  2. I'm unsure about the page view at the moment. I think I would have put "Cancel" at to the far left, but maybe this is a question for @nikolahoff. Do you like it the way it is at the moment?
    grafik

I think you are right, but let's wait for @nikolahoff opinion :)

@nikolahoff
Copy link

I think there are too many buttons and styles on the same page. But maybe we can leave it for now and wait until I have done the overall review because this would effect other pages as well. @JoeyStk @lunars97

@JoeyStk
Copy link
Contributor

JoeyStk commented Dec 2, 2024

@nikolahoff Thanks! Yes, sounds reasonable. Until then, do you have a preference whether or not it should be before or after the "Preview" button? :)

@nikolahoff
Copy link

@JoeyStk I would put it before the preview.

@lunars97 lunars97 force-pushed the feature/add-cancel-button-to-creation-form branch from bb05b38 to 0f6c43c Compare December 3, 2024 13:16
@lunars97 lunars97 requested a review from JoeyStk December 3, 2024 13:20
@JoeyStk JoeyStk self-assigned this Dec 3, 2024
@lunars97 lunars97 force-pushed the feature/add-cancel-button-to-creation-form branch from 0f6c43c to 3b89d43 Compare December 3, 2024 15:36
Copy link
Contributor

@JoeyStk JoeyStk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 🚀

@MizukiTemma
Copy link
Member

MizukiTemma commented Dec 5, 2024

@osmers
I have some questions.

I understood the scope of issue as following: a cancel button should be added to all the forms onto which region users can land if the corresponding object has a tree or list. Therefore meida library, imprint and machine translations are exempt of this change, as they do not have any tree/list, and region, language, users (in Network Management), role, offer template and location category too as they are only available for staff users.

If this interpretation is correct, the button is missing for the form of contact, external calendar and user. I guess the first two are not listed in the issue because they didn't exist at the time of issue open.

And the cancel button will not be shown if the opened object is archived or the user does not have change permission (observer role), but they probably want to go back to the list by the button (once it's introduced) after checking an archived something.

@MizukiTemma MizukiTemma self-requested a review December 5, 2024 18:46
@lunars97
Copy link
Contributor Author

@osmers I have some questions.

I understood the scope of issue as following: a cancel button should be added to all the forms onto which region users can land if the corresponding object has a tree or list. Therefore meida library, imprint and machine translations are exempt of this change, as they do not have any tree/list, and region, language, users (in Network Management), role, offer template and location category too as they are only available for staff users.

If this interpretation is correct, the button is missing for the form of contact, external calendar and user. I guess the first two are not listed in the issue because they didn't exist at the time of issue open.

And the cancel button will not be shown if the opened object is archived or the user does not have change permission (observer role), but they probably want to go back to the list by the button (once it's introduced) after checking an archived something.

@MizukiTemma @osmers should I add cancel button for form of contact, external calendar and user? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants