-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cancel button to creation and edit forms #3251
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
This looks quite good already. I only have two thoughts:
- I think this deserves a release note
- I'm unsure about the page view at the moment. I think I would have put "Cancel" at to the far left, but maybe this is a question for @nikolahoff. Do you like it the way it is at the moment?
I think you are right, but let's wait for @nikolahoff opinion :) |
@nikolahoff Thanks! Yes, sounds reasonable. Until then, do you have a preference whether or not it should be before or after the "Preview" button? :) |
@JoeyStk I would put it before the preview. |
bb05b38
to
0f6c43c
Compare
0f6c43c
to
3b89d43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much 🚀
@osmers I understood the scope of issue as following: a cancel button should be added to all the forms onto which region users can land if the corresponding object has a tree or list. Therefore meida library, imprint and machine translations are exempt of this change, as they do not have any tree/list, and region, language, users (in Network Management), role, offer template and location category too as they are only available for staff users. If this interpretation is correct, the button is missing for the form of contact, external calendar and user. I guess the first two are not listed in the issue because they didn't exist at the time of issue open. And the cancel button will not be shown if the opened object is archived or the user does not have change permission (observer role), but they probably want to go back to the list by the button (once it's introduced) after checking an archived something. |
@MizukiTemma @osmers should I add cancel button for form of contact, external calendar and user? 🤔 |
Short description
Add cancel button to create and update form where user can just go back to the list overview instead of going back through side menu navigation
Proposed changes
Side effects
Resolved issues
Fixes: #2930
Pull Request Review Guidelines