-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test for region deletion #3208
Test for region deletion #3208
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding test 💪 I have some suggestions, please find in the comments 💬
Do you remember when deleting a region caused internal server errors? Ideally we should catch these with the new tests |
These are the three Issues/PRs that I could find:
I will add commits in the next days that also test for these use cases :) |
As I'm busy with a lot of other issues/projects please feel free to contribute to this PR. I don't see myself going back to this PR anytime soon :( |
afd9573
to
711175d
Compare
I'll take over then this PR. Changes and checks so far sugegsted are now applied. |
d27409e
to
2afa96c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good to me :)
redirect = response.headers.get("location") | ||
response = client.get(redirect) | ||
assert ( | ||
"Die Region konnte nicht gelöscht werden, weil die folgenden Seiten in anderen Region gespiegelt werden:" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo here with "Region" instead "Regionen", but it's also in the translation file so I think it's probably just copied from there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, I think singular is correct here, as delete_region
handles actually one single region 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Die Region konnte nicht gelöscht werden, weil die folgenden Seiten in anderen Region gespiegelt werden:" | |
"Die Region konnte nicht gelöscht werden, weil die folgenden Seiten in anderen Regionen gespiegelt werden:" |
I think @jarlhengstmengel was referring to the second occurrence, which should actually be plural.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jarlhengstmengel @david-venhoff
Ah 🙈 Yes, it must be "Regionen" there. #3302
Co-authored-by: MizukiTemma <[email protected]>
2afa96c
to
571af55
Compare
Short description
This PR adds a test for region deletion
Proposed changes
Side effects
Resolved issues
Fixes: #3050
Pull Request Review Guidelines