Add contact creation in POI form #3196
Draft
+154
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MizukiTemma
reviewed
Nov 12, 2024
| @@ -167,6 +167,9 @@ <h3 class="font-bold text-black heading"> | |||
| <div id="right-sidebar-column" | |||
| class="flex flex-col flex-wrap 3xl:col-end-3 4xl:col-end-auto md:w-full"> | |||
| {% include "./poi_form_sidebar/contact_box.html" with box_id="poi-contact" %} | |||
| {% if not poi_form.instance.id and perms.cms.change_contact %} | |||
There was a problem hiding this comment.
Suggested change
| {% if not poi_form.instance.id and perms.cms.change_contact %} | |
| {% if poi_form.instance.id and perms.cms.change_contact %} |
I guess you want to show this box only when an existing POI is being edited, not when a new POI is being created on the POI form.
|
The new typescript file "contact_box.ts" needs to be added in "index.ts", otherwise it can't bring its effects 😿 |
Thank you for the hint! That would have been my question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds the creation of contacts with a collapsible box in the POI form.
Proposed changes
Side effects
Resolved issues
Fixes: #3088
Pull Request Review Guidelines