Improve social media preview #3163
Draft
+10
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenseeberg
force-pushed
the
feature/improve-social-media-previews
branch
from
35489de to
83348ce
Compare
JoeyStk
requested review from
david-venhoff,
charludo,
JoeyStk and
MizukiTemma
JoeyStk
reviewed
Oct 31, 2024
| strip_tags(content.replace("\n", " ").replace("\r", "").replace("<br>", " ")) | ||
| ) | ||
| if len(stripped_content) <= 100: | ||
| return stripped_content.strip().replace(" ", " ") |
There was a problem hiding this comment.
Why do we need this line? :)
There was a problem hiding this comment.
For example
Hallo<br>
Welt
will evaluate to Hallo Welt as we replaced newlines and br tags with empty spaces in line 51.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Improve the social media previews.
More info: https://chat.tuerantuer.org/digitalfabrik/pl/rnoez75xxjyhugxo97mbjuqmte & https://tasks.tuerantuer.org/projects/infra/work_packages/3734/activity?query_id=59
Previews on Signal and WhatsApp are not yet working.
Proposed changes
Side effects
Pull Request Review Guidelines