Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translation coverage row to dashboard #3129

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

JoeyStk
Copy link
Contributor

@JoeyStk JoeyStk commented Oct 12, 2024

Short description

This PR adds the translation coverage row to the dashboard. This branch is already quite old and needs a bit of an update, however I finally wanted to open up this PR to get some feedback in advance

Proposed changes

  • Calculate the number of outdated translations
  • Load the row via AJAX to increase loading time

Side effects

  • Uff... the calculation doesn't seem great. Is someone aware of a better way to do it?

Resolved issues

Fixes: #4


Pull Request Review Guidelines

@jarlhengstmengel
Copy link
Contributor

Do you have a reason why you choose a different approach then translation_coverage_view.py?

@jarlhengstmengel
Copy link
Contributor

Do you have a reason why you choose a different approach then translation_coverage_view.py?

Ah sorry, I overlooked the point about AJAX

@JoeyStk JoeyStk force-pushed the feature/add-translation-coverage-row-to-dashboard branch from 201d766 to 0c35cb1 Compare November 15, 2024 15:12
Copy link
Contributor

@charludo charludo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you! I decided to approve this PR even though I am not 100% sure if the calculation of the number of missing pages can be improved upon. I've added my try below, but feel free to ignore it!

integreat_cms/cms/views/dashboard/dashboard_view.py Outdated Show resolved Hide resolved
@JoeyStk JoeyStk force-pushed the feature/add-translation-coverage-row-to-dashboard branch from 40b30ce to a5ca153 Compare December 10, 2024 09:19
@JoeyStk JoeyStk force-pushed the feature/add-translation-coverage-row-to-dashboard branch from a5ca153 to 1de6db4 Compare December 10, 2024 09:31
@JoeyStk
Copy link
Contributor Author

JoeyStk commented Dec 10, 2024

@jarlhengstmengel I think this PR is ready for review again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add translation coverage to "To-Do" dashboard
3 participants