-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/bulk cancel translation process #3117
base: develop
Are you sure you want to change the base?
Conversation
Code Climate has analyzed commit 55238ca and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.5% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks mostly good to me.
Could you also verify that the a message is shown that the page is not in translation if the page was not in translation before, and that a message is shown that the status was successfully cancelled if the page was in translation before?
For reference, you could do something like that: https://github.com/digitalfabrik/integreat-cms/blob/develop/tests/cms/views/feedback/test_region_feedback_actions.py#L55-L59
@david-venhoff Regarding the archived pages: |
@david-venhoff I also un-archived the pages and moved them to the Nürnberg region to reduce the impact on other tests. |
@theresantonie |
@MizukiTemma |
Short description
New test module to test the functionality of the
CancelTranslationProcess
class inpage_bulk_actions.py
.Proposed changes
Add this test module to the general testing process and the needed test data to
test_data.json
:pages: [30, 31] (Region: nurnberg)
pagetranslations: [100,101]
Side effects
Changed expected results for other tests:
sitemap_nurnberg_de.xml
num_expected_queries for nurnberg_de 78 -> 88
Resolved issues
Fixes: #2915
Pull Request Review Guidelines