Add tests for broken link actions #3096
Open
+424
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit a306330 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.9% (0.4% change). View more on Code Climate. |
MizukiTemma
force-pushed
the
test/link_actions
branch
from
a306330 to
21e107c
Compare
MizukiTemma
force-pushed
the
test/link_actions
branch
from
21e107c to
f94014f
Compare
There was a problem hiding this comment.
Thanks, this looks mostly good to me :)
Could you also add a test case for #3058?
| ) | ||
|
|
||
| assert Link.objects.filter(url__url=OLD_URL).count() == after | ||
| # assert Link.objects.filter(url__url=NEW_URL).count() == before - after |
There was a problem hiding this comment.
Why is this commented out?
There was a problem hiding this comment.
It's failing somehow 😢
Co-authored-by: David Venhoff <[email protected]>
MizukiTemma
force-pushed
the
test/link_actions
branch
from
0e03a0a to
89036fd
Compare
MizukiTemma
added
not-testable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR adds tests for actions users can take in the broken link list.
Proposed changes
Side effects
Resolved issues
Fixes: #3062
Pull Request Review Guidelines