Add @tree_mutex() decorator and trick treebeard into using transactions #3076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit b43b88a and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 93.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 82.5% (0.0% change). View more on Code Climate. |
This was referenced Sep 25, 2024
PeterNerlich
requested review from
ulliholtgrave,
timobrembeck and
david-venhoff
PeterNerlich
force-pushed
the
bugfix/tree_mutex
branch
from
af20e01 to
359f47f
Compare
PeterNerlich
force-pushed
the
bugfix/tree_mutex
branch
2 times, most recently
from
5facfee to
d800e0f
Compare
Co-authored-by: Sven Seeberg <[email protected]> Co-authored-by: Ulli Holtgrave <[email protected]> Co-authored-by: Timo Brembeck <[email protected]>
PeterNerlich
force-pushed
the
bugfix/tree_mutex
branch
from
d800e0f to
b43b88a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
Force treebeard to use transactions. This should remove any race conditions caused by the library. The tests seem promising.
Proposed changes
@tree_mutex()decorator to replace@django.db.transactions.atomic(still uses it inside in addition to the mutex implementation)@tree_mutex()Side effects
Resolved issues
Fixes: #1518, possibly #1716
Pull Request Review Guidelines