[7.11.24] Add form for contact information

[MizukiTemma]

Short description

This PR implements a new form for contact objects.

This PR is not yet finalized. Changes from #3007 have been taken over but are not actual in this branch. Once it is merged, this PR will be updated too.

To Do after #3007 is merged

• Add the real URL to contacts listed in poi_form_sidebar/action_box.html

Proposed changes

• Add three new boolean fields to the model contact to store whether E-mail, phone number and website must be imported from the related POI.
• Make the fields for E-mail, phone number and website read-only when the corresponding check box is checked.
• Create a new form ContactForm with check whether those three fields match with those of the selected POI if checked for import from the POI
• Create a new template for the form, reusing poibox.html and _related_contents_table.html

Side effects

• Change the field name "poi" to "location" in the contact model to be compatible with poi_box.html

Memo

• There is not yet any implementation to find contents in which the contact is used. Third box "Contact information" is currently only a place hlder. This will be implemented during [2024-11-07] Add contact as choice for "insert" in TinyMCE #2959

Resolved issues

Fixes: #2953

---

Pull Request Review Guidelines

[codeclimate]

Code Climate has analyzed commit e01c256 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 62.3% (50% is the threshold).

This pull request will bring the total coverage in the repository to 82.4% (0.0% change).

View more on Code Climate.

[MizukiTemma]

Update after exchange with @osmers : Name should not be mandatory anymore. It should be possible to create a contact only with position or department name (which will be given in the field "title") without name of individual person.

done

[david-venhoff]

Cool 🎉

I have a few suggestions

[PeterNerlich]

I agree with most of davids comments, so mine are only what caught my eye on top of them.

[MizukiTemma]

@david-venhoff @PeterNerlich
The check boxes and related codes are removed. Could you review again?

[david-venhoff]

Looks good to me! The only thing missing are the changes to which fields are required I think.

In the details block are some nits, but I don't think they are required to merge this :)

I noticed that `Pages` does not line up with `Title` 

But I did not find a quick fix, and it is probably not that important 🤷

When a user starts to edit a contact and then clicks on the archive or delete button, the unsaved warning will show up, which probably should not happen. But I guess this is also not important and probably would never happen ^^

[PeterNerlich]

@david-venhoff: I noticed that `Pages` does not line up with `Title`. But I did not find a quick fix, and it is probably not that important 🤷

This is because for the last column, this note is in its own div.p-4, while the other columns have it in a div.p-4 along with more content. The message and the following headline each have margins set, which don't add but collapse to the greater margin of both elements, while in the last column they each fully take up space, plus the padding from both div.p-4.

If we don't want to change _related_contents_table.html to have the outermost element only be a div.w-full.table-listing and push the responsibility of giving appropriate spacing to wherever it is being embedded (I don't know whether we have any conventions regarding html snippets like this), we could change all columns to have the hint on top to uniformly be in a separate div.p-4.pb-0.

[david-venhoff]

LGTM 🎉

I'd just propose to move the new contact constraints to the database layer, instead of performing them at the form-level.

[PeterNerlich]

Looks good to me. It feels nice to use with the way we settled to do the constraints now, I think revisiting those was worth it. Thank you very much!