-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When editing a contact and removing the location it hides the other grid items #3151
Comments
If editing a contact should have the same behaviour as creating a new contact as defined in this design then this issue can be closed again: https://www.figma.com/design/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1752-1636 |
I think we could maybe grey out the two sections that are currently disappearing to indicate that they cannot be changed without a poi being selected? |
@nikolahoff What do you think? |
That works well too :) good idea |
@juliankehne @osmers yes we should indicate that the location is mandatory and not hiding the other 2 input columns. It could be confusing and could seem like the other information is gone and needs to create a whole new contact. Editing follows the same bahaviour like for users herehttps://admin.integreat-app.de/testumgebung/users/1709/edit/ |
@osmers do we need to create a new ticket for this? |
@nikolahoff I don't think we need a new ticket - maybe it's enough that you comment once the design is ready for this? And maybe put the link to the design in the comment? But I'll pass the question to @JoeyStk in case he does not agree. |
Yes, I agree with @osmers. You can just use this ticket until the design is done :) |
I think this is the design for the new workflow: https://www.figma.com/design/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1629-2&node-type=canvas&t=gNzRYazMXvxfChmS-0 @JoeyStk |
@nikolahoff Is this design finalized? Then I'd remove the ui-ux label. |
Yes, sorry I forgot to post the link. The finalized design is here |
Describe the Bug
When editing an existing Contact and removing the Location (trash icon) from the contact it hides the grid items "Manage contact data" and "Contact information"
Steps to Reproduce
Expected Behavior
When editing an already existing contact the two grid items should stay visible
Actual Behavior
When editing an already existing contact the two grid items are hidden after the location was removed
Additional Information
Hiding the grid items items is great during the creation of a contact, but I think it is confusing when editing a contact and some of the existing information is suddenly not visible anymore.
Before removing the location:
After removing the location:
Traceback
The text was updated successfully, but these errors were encountered: