Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When editing a contact and removing the location it hides the other grid items #3151

Open
Tracked by #2955
juliankehne opened this issue Oct 23, 2024 · 12 comments · May be fixed by #3292
Open
Tracked by #2955

When editing a contact and removing the location it hides the other grid items #3151

juliankehne opened this issue Oct 23, 2024 · 12 comments · May be fixed by #3292
Assignees
Labels
blocker This issue blocks another issue bug Something isn't working
Milestone

Comments

@juliankehne
Copy link

Describe the Bug

When editing an existing Contact and removing the Location (trash icon) from the contact it hides the grid items "Manage contact data" and "Contact information"

Steps to Reproduce

  1. Go to 'Contacts'
  2. Open an existing contact to edit it
  3. Click the trash bin icon to remove the location from the contact
  4. See that grid items "Manage contact data" and "Contact information" are now hidden

Expected Behavior

When editing an already existing contact the two grid items should stay visible

Actual Behavior

When editing an already existing contact the two grid items are hidden after the location was removed

Additional Information

Hiding the grid items items is great during the creation of a contact, but I think it is confusing when editing a contact and some of the existing information is suddenly not visible anymore.

Before removing the location:
2024-10-23 16_04_19-Integreat Editorial System — Mozilla Firefox

After removing the location:
2024-10-23 16_04_33-Integreat Editorial System — Mozilla Firefox

Traceback
@juliankehne
Copy link
Author

If editing a contact should have the same behaviour as creating a new contact as defined in this design then this issue can be closed again:

https://www.figma.com/design/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1752-1636

@osmers
Copy link

osmers commented Oct 23, 2024

I think we could maybe grey out the two sections that are currently disappearing to indicate that they cannot be changed without a poi being selected?

@juliankehne
Copy link
Author

As I understand it we are hiding the grids during creation to guide the user through the process. But theoretically we don't have to do that as long as a location is selected in the end and all other mandatory fields are filled out.

And if a user tries saving without a location selected it does return an error message already:
2024-10-23 16_28_05-Integreat Editorial System — Mozilla Firefox

So when editing an existing contact I don't think we need to guide the user through the process again, be it via hiding or greying out the fields.

What I can think of is that we could put an indicator that Location has to be selected, once the user removes the current location.

@juliankehne
Copy link
Author

@nikolahoff What do you think?

@osmers
Copy link

osmers commented Oct 23, 2024

So when editing an existing contact I don't think we need to guide the user through the process again, be it via hiding or greying out the fields.

What I can think of is that we could put an indicator that Location has to be selected, once the user removes the current location.

That works well too :) good idea

@nikolahoff
Copy link

nikolahoff commented Oct 28, 2024

@juliankehne @osmers yes we should indicate that the location is mandatory and not hiding the other 2 input columns. It could be confusing and could seem like the other information is gone and needs to create a whole new contact. Editing follows the same bahaviour like for users herehttps://admin.integreat-app.de/testumgebung/users/1709/edit/
I will add the info in the design and the indicator for location.

@nikolahoff
Copy link

@osmers do we need to create a new ticket for this?

@osmers osmers added the bug Something isn't working label Oct 28, 2024
@osmers osmers added this to the 24Q4 milestone Oct 28, 2024
@osmers
Copy link

osmers commented Oct 28, 2024

@nikolahoff I don't think we need a new ticket - maybe it's enough that you comment once the design is ready for this? And maybe put the link to the design in the comment? But I'll pass the question to @JoeyStk in case he does not agree.

@JoeyStk JoeyStk added the ui-ux Issues that requires an UI/UX perspective. label Oct 28, 2024
@JoeyStk
Copy link
Contributor

JoeyStk commented Oct 28, 2024

Yes, I agree with @osmers. You can just use this ticket until the design is done :)

@osmers
Copy link

osmers commented Nov 19, 2024

I think this is the design for the new workflow: https://www.figma.com/design/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1629-2&node-type=canvas&t=gNzRYazMXvxfChmS-0 @JoeyStk

@JoeyStk JoeyStk modified the milestones: 24Q4, 25Q1 Dec 3, 2024
@JoeyStk JoeyStk added the blocker This issue blocks another issue label Dec 3, 2024
@MizukiTemma
Copy link
Member

I think this is the design for the new workflow: https://www.figma.com/design/6U7R7Xj4wL7sbjxKRmOG9D/CMS-Project?node-id=1629-2&node-type=canvas&t=gNzRYazMXvxfChmS-0 @JoeyStk

@nikolahoff Is this design finalized? Then I'd remove the ui-ux label.

@nikolahoff
Copy link

Yes, sorry I forgot to post the link. The finalized design is here

@MizukiTemma MizukiTemma removed the ui-ux Issues that requires an UI/UX perspective. label Dec 9, 2024
@MizukiTemma MizukiTemma self-assigned this Dec 10, 2024
@MizukiTemma MizukiTemma linked a pull request Dec 12, 2024 that will close this issue
@JoeyStk JoeyStk modified the milestones: Roadmap T37K, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker This issue blocks another issue bug Something isn't working
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

5 participants