Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent orphaned contact cards #3282

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

charludo
Copy link
Contributor

@charludo charludo commented Dec 9, 2024

DRAFT until #3169 is merged

Short description

Prevent the deletion of contacts as long as pages/pois/events still referr to it. Note that no list of objects referring to the contact in question is shown in the error message, since we show that list in the contact details anyways.

Proposed changes

  • prevent deletion of contacts in the edit view
  • prevent deletion in the bulk action view

Side effects

  • none

Resolved issues

Fixes: #3260


Pull Request Review Guidelines

@charludo charludo linked an issue Dec 9, 2024 that may be closed by this pull request
@MizukiTemma
Copy link
Member

@charludo
Could you add the same check for archiving too? 😸

@MizukiTemma MizukiTemma added the blocked Blocked by external dependency label Dec 9, 2024
@charludo charludo force-pushed the enhancement/prevent-orphaned-contact-cards branch from 4967b5c to b2e6bb2 Compare December 10, 2024 06:20
@charludo
Copy link
Contributor Author

@charludo Could you add the same check for archiving too? 😸

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by external dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent orphaned contact cards
2 participants