Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent orphaned contact cards #3260

Open
Tracked by #2955
MizukiTemma opened this issue Dec 3, 2024 · 3 comments · May be fixed by #3282
Open
Tracked by #2955

Prevent orphaned contact cards #3260

MizukiTemma opened this issue Dec 3, 2024 · 3 comments · May be fixed by #3282
Assignees
@charludo
Labels
effort: low Should be doable in <4h enhancement This improves an existing feature feature New feature or request prio: high Needs to be resolved ASAP.
Milestone
Next-up

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Dec 3, 2024 •
edited
Loading

Motivation

#3169 introduces a functionality to embed a contact as a card into contents (pages, events, locations). It is currently possible to archive/delete a contact object that is embedded in a content. After archiving/deleting an embedded contact object, its contact card remains in the content. This will be chaoric in future.

Proposed Solution

Either

  • Prevent archiving/deleting contact objects that are embedded somewhere (like objects of other models)
    or
  • Delete embedded contact cards when their contact objects is archived/deleted (with warning and confirmation button)

Alternatives

Ignore this potential problem

User Story

Additional Context

Wait for #3169

Design Requirements

Related Issues
@MizukiTemma MizukiTemma added the feature New feature or request label Dec 3, 2024
@MizukiTemma MizukiTemma added this to the Meta Issues milestone Dec 3, 2024
This was referenced Dec 3, 2024
Merged
Open
@charludo
Copy link
Contributor

charludo commented Dec 3, 2024

Ohh, good catch!!

@JoeyStk JoeyStk added enhancement This improves an existing feature question Further information is requested effort: low Should be doable in <4h labels Dec 3, 2024
@JoeyStk
Copy link
Contributor

JoeyStk commented Dec 3, 2024

@osmers We would lean towards the first proposed solution. Do you agree with us? :)

@JoeyStk JoeyStk added the prio: high Needs to be resolved ASAP. label Dec 3, 2024
@osmers
Copy link

osmers commented Dec 4, 2024

Yeah, I agree - it's the same behaviour we already have with live content and POIs used in events for example, right? Would make sense then to have a similar list e.g.

This contact cannot be archived because it is used by the following page/event/POI

@MizukiTemma MizukiTemma modified the milestones: Meta Issues, 24Q4 Dec 4, 2024
@MizukiTemma MizukiTemma removed the question Further information is requested label Dec 4, 2024
@charludo charludo self-assigned this Dec 9, 2024
@charludo charludo linked a pull request Dec 9, 2024 that will close this issue
Draft
@charludo charludo linked a pull request Dec 9, 2024 that will close this issue
Prevent orphaned contact cards #3282
Draft
@JoeyStk JoeyStk modified the milestones: 24Q4, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charludo charludo

Labels
effort: low Should be doable in <4h enhancement This improves an existing feature feature New feature or request prio: high Needs to be resolved ASAP.
Projects
None yet
Milestone
Next-up
Development

Successfully merging a pull request may close this issue.

Prevent orphaned contact cards digitalfabrik/integreat-cms
4 participants
@charludo @osmers @JoeyStk @MizukiTemma