Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cancel button to creation form of page, poi, event, organisation, language node, push notification and users #2930

Open
osmers opened this issue Jul 25, 2024 · 4 comments · May be fixed by #3251
Open

Add cancel button to creation form of page, poi, event, organisation, language node, push notification and users #2930

osmers opened this issue Jul 25, 2024 · 4 comments · May be fixed by #3251
Assignees
@lunars97
Labels
feature New feature or request good first issue Good for newcomers prio: low Not urgent, can be resolved in the distant future.
Milestone
Next-up

Comments

@osmers
Copy link

osmers commented Jul 25, 2024

Motivation

A clear button that lets users cancel the current creation process they started is more intuitive than simply clicking on a menu item to leave the form

Proposed Solution

Add a red cancel button to each creation form listed above. Maybe also to the edit forms? At least for pages, pois and events we would have to discuss the effect of the button (i.e. what to do with automatic saves etc)

Alternatives

Keep it as it is

User Story

As a user of the CMS I want to have a clear button that let's me cancel the changes I have made in order to be sure that no changes are saved and nothing was created.

Additional Context

Same button as for automatic translations bulk action:
image
@osmers osmers added feature New feature or request good first issue Good for newcomers prio: low Not urgent, can be resolved in the distant future. labels Jul 25, 2024
@osmers osmers added this to the 24Q4 milestone Jul 25, 2024
@MizukiTemma
Copy link
Member

Where should it redirect after clicking the button? Probably to the list (cancel on the organigation form -> the organization list)?

@MizukiTemma MizukiTemma mentioned this issue Aug 22, 2024
Closed
@osmers
Copy link
Author

osmers commented Aug 22, 2024

@MizukiTemma yes, exactly - basically back to the page where you clicked on the create button...

@JoeyStk JoeyStk modified the milestones: 24Q4, 25Q1 Oct 8, 2024
@lunars97 lunars97 self-assigned this Nov 27, 2024
@lunars97
Copy link
Contributor

lunars97 commented Nov 27, 2024 •
edited
Loading

@nikolahoff should we change the cancel button color to ghost-button (instead of red which is used for delete) and from now on use this color for all cancel buttons? 🤔 This question is also mentioned here #2966

@nikolahoff
Copy link

@lunars97 cancel button should have this behaviour like in this design
Delete buttons are different. For now we keep it like it is for delete. Maybe with the overall redesign we might change it.

@lunars97 lunars97 linked a pull request Nov 29, 2024 that will close this issue
Open
@JoeyStk JoeyStk modified the milestones: Roadmap T37K, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lunars97 lunars97

Labels
feature New feature or request good first issue Good for newcomers prio: low Not urgent, can be resolved in the distant future.
Projects
None yet
Milestone
Next-up
Development

Successfully merging a pull request may close this issue.

Add cancel button to creation and edit forms digitalfabrik/integreat-cms
5 participants
@osmers @JoeyStk @lunars97 @MizukiTemma @nikolahoff