Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-11-07] Add a button to create a contact in the POI form. #3088

Open
Tracked by #2955
MizukiTemma opened this issue Oct 1, 2024 · 10 comments · May be fixed by #3196
Open
Tracked by #2955

[2024-11-07] Add a button to create a contact in the POI form. #3088

MizukiTemma opened this issue Oct 1, 2024 · 10 comments · May be fixed by #3196
Assignees
Labels
deadline Needs to be fixed in the given time feature New feature or request prio: high Needs to be resolved ASAP.
Milestone

Comments

@MizukiTemma
Copy link
Member

Motivation

A new feature contact is being implemented. It helps users if there is a possibility to create a contact directly in the POI form.

Proposed Solution

Implement an ajax form like POI creation in the event form.

Alternatives

Don't implement.

User Story

Additional Context

Design Requirements

@MizukiTemma MizukiTemma added the feature New feature or request label Oct 1, 2024
@MizukiTemma MizukiTemma added this to the 24Q4 milestone Oct 1, 2024
@MizukiTemma MizukiTemma changed the title Add a button to create a contact in the POI form. [7.11.24] Add a button to create a contact in the POI form. Oct 1, 2024
@MizukiTemma MizukiTemma added prio: high Needs to be resolved ASAP. deadline Needs to be fixed in the given time labels Oct 1, 2024
@jarlhengstmengel jarlhengstmengel self-assigned this Oct 2, 2024
@JoeyStk JoeyStk changed the title [7.11.24] Add a button to create a contact in the POI form. [2024-11-07] Add a button to create a contact in the POI form. Oct 4, 2024
@jarlhengstmengel
Copy link
Contributor

Is the relationship between POI/Location and Contact a 1:0..1 relationship?

@PeterNerlich
Copy link
Collaborator

Is the relationship between POI/Location and Contact a 1:0..1 relationship?

No, Location and Contact are in a 0..1:0..n relationship: A Contact MAY reference a Location, there can be Locations that are not referenced by any Contact. But there is an additional constraint on the model that there can be at most one Contact with an empty title / point of contact for field per referenced Location

@jarlhengstmengel
Copy link
Contributor

So a contact can be created without referencing a location?

@jarlhengstmengel
Copy link
Contributor

So a contact can be created without referencing a location?

NVM

@PeterNerlich
Copy link
Collaborator

No, that's my mistake, I think a contact always has to reference a location after all

@jarlhengstmengel jarlhengstmengel linked a pull request Nov 11, 2024 that will close this issue
@jarlhengstmengel
Copy link
Contributor

@osmers the question came up if the creation of a contact in the POI form should only be available during the editing of a POI or also during the creation?

@osmers
Copy link

osmers commented Nov 19, 2024

@jarlhengstmengel how are we handling that with events? I think I would implement the same process here.

@jarlhengstmengel
Copy link
Contributor

@jarlhengstmengel how are we handling that with events? I think I would implement the same process here.

Events is doing both I think. Contact creation during POI creation is a bit more complicated as the creation during editing since a contact needs to reference a POI, but it should be doable. I will probably split this issue into two PRs then

@osmers
Copy link

osmers commented Nov 20, 2024

@jarlhengstmengel that's a fair point though - I hadn't thought of this...
We could do it this way:
1st Prio - contact creation once POI is already saved
2nd Prio - contact creation before POI is saved (not really that urgent, I think, especially if it would delay the release. I think it's always an improvement we can release later)
What do you think?

@jarlhengstmengel
Copy link
Contributor

Sounds good to me :)

@JoeyStk JoeyStk modified the milestones: 24Q4, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time feature New feature or request prio: high Needs to be resolved ASAP.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants