Add a query optimization class #99
Open
+147
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Example optimization -
|
svenseeberg
reviewed
Dec 12, 2024
| ) | ||
| else: | ||
| message = data["message"] | ||
|
|
||
| answer_service = AnswerService(data["region"], rag_language) | ||
| if answer_service.needs_answer(data["message"]): | ||
| if settings.RAG_QUERY_OPTIMIZATION: | ||
| message = answer_service.optimize_query_for_retrieval(message) |
There was a problem hiding this comment.
If the optimize_query_for_retrieval() is not needed anymore, we can directly remove it from the AnswerService?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A check is performed before query optimzation using an LLM based on the following criteria. If query is "simple", it is not changed.
Length -
A query length greater than a certain number of characters is deemed complicated (The parameter is currently in the class. Can be moved to settings.py later )
Punctuation -
Three punctuations are considered (period, comma, question mark) in different languages ( More language support can be added ). If the query contains multiple sentences(more than 1 period), multiple commas or question marks, it is deemed to be complicated