-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1137: Adding new intro slides #3014
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the design, just a few minor comments :) Thank you!
One more thing: Please delete the old assets as they are not needed anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I approved by accident
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found one other issue: If moving to the last slide, everything jumps down a bit, see video. After that everything stays that way, i.e. it does not jump back up.
screen-20241217-113247.mp4
Tested for malte, works fine! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on android, did not find any issues. Really well done. Please check all open comments and resolve them. Please also check the proposal in #3027.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on android, nice work! Please squash the commits when merging :)
Short description
Changing and adding new intro slides to look like this here
Proposed changes
TextButton
to let me change text styling.build-configs/common/assets
currentColor
)Note: not tested on iOS.
Side effects
Testing
Fixes: #1137