Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2918: Add tts on web #2985

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
+888 −240
Draft

2918: Add tts on web #2985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
9530674
TTS for web part1 testing SpeechSynthesis
bahaaTuffaha Oct 7, 2024
9eb0b45
2918: More improvements to tts
bahaaTuffaha Oct 8, 2024
53a59cc
2918: more enhancement to speechSynthesis
bahaaTuffaha Oct 9, 2024
a0bc6a1
2918: Refactoring TtsPlayer
bahaaTuffaha Oct 20, 2024
d838533
2918: used easy-speech cross platform support
bahaaTuffaha Oct 25, 2024
a3a4dbf
more improvements to ttsWeb
bahaaTuffaha Oct 28, 2024
c0741da
2918: Adding TtsContextProvider and more improvements
bahaaTuffaha Oct 29, 2024
8592cec
2918 :Adding Mocks and test also adjusting the TtsHelpModal
bahaaTuffaha Oct 30, 2024
8acb476
2918: Fixing TtsPlayer test file and more improvements
bahaaTuffaha Oct 31, 2024
5ec63a2
2918: Fixing volume and changes for TtsHelpModal
bahaaTuffaha Nov 5, 2024
e4fecf3
2918: Trying to solve onEnd issue
bahaaTuffaha Nov 6, 2024
ac7f3d8
Merge branch 'main' into 2918-Add-TTS-on-web
bahaaTuffaha Nov 6, 2024
5d8a435
Merge remote-tracking branch 'origin' into 2918-Add-TTS-on-web
bahaaTuffaha Nov 11, 2024
a36dee7
2918: Fixing a bug where I cant redirect to the categories and remove…
bahaaTuffaha Nov 11, 2024
af707de
2918: Small Refactoring for codeSense
bahaaTuffaha Nov 11, 2024
8805341
2918: Adding tts to FeatureFlagsType
bahaaTuffaha Nov 12, 2024
2ee6fdb
Fixing the codeSense error for CategoriesPage at navigateToCategories
bahaaTuffaha Nov 12, 2024
b720631
2918: Splitting Tts for web into TtsPlayer and TtsContainer plus remo…
bahaaTuffaha Nov 19, 2024
366397f
Merge remote-tracking branch 'origin' into 2918-Add-TTS-on-web
bahaaTuffaha Nov 19, 2024
b24583a
2918: changes similar to tts-Android replacing react Dispatch and tit…
bahaaTuffaha Nov 20, 2024
1ff36c5
2918: Modifying to be similar to TtsOnAndroid
bahaaTuffaha Dec 11, 2024
2631024
Merge branch 'main' into 2918-Add-TTS-on-web
bahaaTuffaha Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions assets/icons/book.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions assets/icons/pause.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions assets/icons/play.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions assets/icons/playback.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions assets/icons/readAloud.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions build-configs/BuildConfigType.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ export type FeatureFlagsType = FixedCityType & {
cityNotCooperating?: boolean
cityNotCooperatingTemplate: string | null
chat: boolean
tts: boolean
}

// Available on all platforms
Expand Down
1 change: 1 addition & 0 deletions build-configs/aschaffenburg/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ const commonAschaffenburgBuildConfig: CommonBuildConfigType = {
fixedCity: 'hallo',
cityNotCooperatingTemplate: null,
chat: false,
tts: false,
},
aboutUrls: {
default: 'https://www.aschaffenburg.de/halloaschaffenburg',
Expand Down
4 changes: 4 additions & 0 deletions build-configs/common/theme/colors.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ export type ColorsType = {
warningColor: string
linkColor: string
themeContrast: string
ttsPlayerWarningBackground: string
warning_amber: string
}
export const commonLightColors = {
backgroundAccentColor: '#fafafa',
Expand All @@ -34,4 +36,6 @@ export const commonLightColors = {
invalidInput: '#B3261E',
warningColor: '#FFA726',
linkColor: '#0b57d0',
ttsPlayerWarningBackground: 'rgba(255, 253, 230, 1)',
warning_amber: 'rgba(249, 124, 0, 1)',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not use _ in names. Use camelCase instead. Also please do not put the actual name of the color in the variable nameing, because then it would need renaming if the color changes.
Please stay consistent, either prefix both variables with "ttsPlayer" or none of them

}
1 change: 1 addition & 0 deletions build-configs/integreat-e2e/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ const integreatE2e = {
fixedCity: null,
cityNotCooperatingTemplate,
chat: false,
tts: false,
},
}
const commonIntegreatE2eBuildConfig: CommonBuildConfigType = {
Expand Down
1 change: 1 addition & 0 deletions build-configs/integreat-test-cms/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const integreatTestCms = {
fixedCity: null,
cityNotCooperatingTemplate,
chat: true,
tts: true,
},
}
export const commonIntegreatTestCmsBuildConfig: CommonBuildConfigType = {
Expand Down
1 change: 1 addition & 0 deletions build-configs/integreat/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ const commonIntegreatBuildConfig: CommonBuildConfigType = {
fixedCity: null,
cityNotCooperatingTemplate,
chat: true,
tts: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this "false". Do we only want this feature on beta for now?

},
aboutUrls: {
default: 'https://integreat-app.de/about/',
Expand Down
1 change: 1 addition & 0 deletions build-configs/malte-test-cms/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ const commonMalteTestCmsBuildConfig: CommonBuildConfigType = {
fixedCity: null,
cityNotCooperatingTemplate: null,
chat: false,
tts: false,
},
}

Expand Down
1 change: 1 addition & 0 deletions build-configs/malte/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ const commonMalteBuildConfig: CommonBuildConfigType = {
fixedCity: null,
cityNotCooperatingTemplate: null,
chat: false,
tts: false,
},
aboutUrls: {
default: 'https://www.malteser-werke.de/malte-app',
Expand Down
1 change: 1 addition & 0 deletions build-configs/obdach/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ const commonObdachBuildConfig: CommonBuildConfigType = {
fixedCity: null,
cityNotCooperatingTemplate: null,
chat: false,
tts: false,
},
aboutUrls: {
default: 'https://tuerantuer.de/digitalfabrik/projekte/netzwerkobdachwohnen/',
Expand Down
1 change: 1 addition & 0 deletions native/src/constants/__mocks__/buildConfig.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ const buildConfig = jest.fn<CommonBuildConfigType, []>(
fixedCity: null,
cityNotCooperatingTemplate: 'template',
chat: false,
tts: false,
},
aboutUrls: {
default: 'https://integreat-app.de/about/',
Expand Down
6 changes: 6 additions & 0 deletions release-notes/unreleased/2918-Add-TTS-on-web.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
issue_key: 2918
show_in_stores: true
platforms: # relevant platforms, possible values: web, android and ios
- web
en: Added an exciting new Text-to-Speech feature!
de: Eine spannende neue Text-zu-Sprache-Funktion wurde hinzugefügt!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either remove this release_note or enable the feature on production, by also setting tts to true in the build-config for integreat.

Loading
Loading