Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1840: Properly serialize activity log and fix it #1844

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

steffenkleinle
Copy link
Member

Short description

The activity log was broken for a while due to serializing not happening properly. This introduces proper typing and serializing.

Proposed changes

  • Add fromSerialized and serialize methods to each extension and for cards
  • Properly serialize activity log and use iso8601

Side effects

  • Old activity logs break the serializing (but this should not happen as they are only session based)

Testing

See issue.

Resolved issues

Fixes: #1840

@steffenkleinle
Copy link
Member Author

The additional fromSerialized and serialize methods for extensions are only necessary if user display strings are different form serialized values. Currently, this is only the case for dates (dd.MM.yyyy vs yyyy-MM-dd (ISO8601)). Obviously, we could also serialize dates as dd.MM.yyyy but I think in the long term this is better and provides more flexibility. Let me know if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix broken activity log
2 participants