Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1836: Carousel exception fix #1837

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

1836: Carousel exception fix #1837

wants to merge 1 commit into from

Conversation

f1sh1918
Copy link
Contributor

Short description

Exception is thrown since the controller of the carousel was not ready before execute the jump to function

Proposed changes

  • Wait for the controller to be ready until jumping to a particular card index

Side effects

  • none

Testing

  • Add two cards after each other and check that after the second activation you will be forwarded to the correct card (that you recently activated)

Resolved issues

Fixes: #1836

@f1sh1918 f1sh1918 force-pushed the 1836-carousel-exception-fix branch from 629b706 to ecd5ebe Compare December 11, 2024 12:55
ztefanie
ztefanie approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@ztefanie ztefanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Android Nürnberg. Works as expected 🚀

michael-markl
michael-markl approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@michael-markl michael-markl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me codewise. Did not test anything.

I believe we do not need the wrapping with WidgetsBinding.instance.addPostFrameCallback. It seems unnecessary to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztefanie ztefanie ztefanie approved these changes

@michael-markl michael-markl michael-markl approved these changes

@steffenkleinle steffenkleinle Awaiting requested review from steffenkleinle steffenkleinle is a code owner

@seluianova seluianova Awaiting requested review from seluianova seluianova is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Null check operator used on a null value for carousel controller [dev]
3 participants
@f1sh1918 @michael-markl @ztefanie