1430: Extend card add params #1803

f1sh1918 · 2024-11-27T11:40:19Z

Short description

As a user i want the forms in the self service portal to be prefilled with my personal information if i click "Karte verlängern" with an existing card

Note

I'm not super happy with this solution, but since we can not generate proper functions from the frontend/build-configs/index to the buildConfig.dart to provide a function for each project to generate the applicationUrl with (or without) queryParams i didn't find a better solution.

I mean we could maybe adjust the build config generation to be able to generate functions with parameters but this means lots of effort.

At least this solution avoids multiple linting ignore that would be needed if we provide a query param key object instead of single string values that can be null. Feel free to suggest a better solution but beware that you should run the buildConfig for all the projects to ensure that nothing breaks.

Proposed changes

pass query params keys to the app, ensure that they are the same as in administration
provide a function that return the applicationUrl with queryParams
open the self service portal with queryParams if a card exists
add tests
workaround for Fix more actions button not properly displayed #1802

Side effects

may create a wrong applicationUrl for other projects. so open "Beantragen" for other projects

Testing

Create a card for koblenz that is less than 90 days valid from now
Activate this card
Change the end date in "UserEntitlements" to a later date (or in the csv file and reimport the csv)
Click on the "Karte verlängern" Button or go to more actions and extend the card there
All form fields should be prefilled with valid information
Note: I also tested "Umlaute and dots" and everything worked fine. Please also test that properly

Resolved issues

partially fixes: #1430

…workaround to fix display of more actions button

…nd-card-add-params # Conflicts: # frontend/lib/identification/card_detail_view/card_detail_view.dart # frontend/lib/identification/card_detail_view/extend_card_notification.dart # frontend/lib/identification/util/card_info_utils.dart

ztefanie

Tried to test this, the query params are set correctly, but the fields are not prefilled for me.

the url is: localhost:3000/erstellen?Name=Stefanie+Test&Geburtsdatum=10.06.2003&Referenznummer=123K

frontend/build-configs/types.ts

frontend/build-configs/constants/index.ts

f1sh1918 · 2024-11-28T13:49:09Z

Tried to test this, the query params are set correctly, but the fields are not prefilled for me.

the url is: localhost:3000/erstellen?Name=Stefanie+Test&Geburtsdatum=10.06.2003&Referenznummer=123K

Interesting I tested this on ios and worked fine even this shouldn't be related to this pr.
Will test this again (and on android)

f1sh1918 · 2024-12-02T10:54:04Z

@ztefanie
i can not reproduce it on android. even dunno why inapp browser is opening maybe this is the issue

frontend/build-configs/bayern/index.ts

frontend/lib/util/get_application_url.dart

steffenkleinle · 2024-12-02T11:05:59Z

frontend/lib/util/get_application_url.dart

+String getApplicationUrlWithParameters(
+    String applicationUrl,
+    CardInfo cardInfo,
+    String projectId,
+    String? applicationUrlQueryKeyName,
+    String? applicationUrlQueryKeyBirthday,
+    String? applicationUrlQueryKeyReferenceNumber) {


Suggested change

String getApplicationUrlWithParameters(

String applicationUrl,

CardInfo cardInfo,

String projectId,

String? applicationUrlQueryKeyName,

String? applicationUrlQueryKeyBirthday,

String? applicationUrlQueryKeyReferenceNumber) {

String getApplicationUrlWithParameters(BuildContext context, CardInfo cardInfo) {

final applicationUrl = getApplicationUrl(context);

final projectId = buildConfig.projectId.production;

final applicationUrlQueryKeyName = buildConfig.applicationUrlQueryKeyName;

final applicationUrlQueryKeyBirthday = buildConfig.applicationUrlQueryKeyBirthday;

final applicationUrlQueryKeyReferenceNumber = buildConfig.applicationUrlQueryKeyReferenceNumber;

if i change that, we need some linting ignores for null checks, since these values don't exist for all projects

frontend/build-configs/types.ts

seluianova · 2024-12-02T11:17:55Z

Tried to test this, the query params are set correctly, but the fields are not prefilled for me.

it seems I have the same issue on the current branch.
but on main it works if I apply this: #1806
this particular fix is probably not related, but I think we can try to merge it and update the current branch... 🤔

f1sh1918 · 2024-12-02T11:52:29Z

Tried to test this, the query params are set correctly, but the fields are not prefilled for me.

it seems I have the same issue on the current branch. but on main it works if I apply this: #1806 this particular fix is probably not related, but I think we can try to merge it and update the current branch... 🤔

ok i will merge recent main when you pr was merged

ztefanie

Not tested again.

frontend/lib/identification/identification_page.dart

steffenkleinle

I had to run yarn tsc --build once to get administration to pick up the changes in frontend/build-configs. Tested on firefox, works as expected! Thanks for putting time into this, seems like quite a nasty thing...

…test improvements, only add queryParams if card is extendable

frontend/lib/util/get_application_url.dart

frontend/lib/identification/identification_page.dart

seluianova · 2024-12-02T17:36:40Z

Just added a couple of optional nit-picks, because overall it looks good 👍
But I'm concerned about the following:

ok i will merge recent main when you pr was merged

The form is still not being filled out for me 🤔
Even if I open the link with params in the desktop browser, the form is not filled out, so it doesn't seem to be related to the app or emulator.
It works on main for me, but doesn't work on the current branch...
Especially strange if it's only reproduced for me and Steffi...

f1sh1918 · 2024-12-02T21:22:17Z

Just added a couple of optional nit-picks, because overall it looks good 👍 But I'm concerned about the following:

ok i will merge recent main when you pr was merged

The form is still not being filled out for me 🤔 Even if I open the link with params in the desktop browser, the form is not filled out, so it doesn't seem to be related to the app or emulator. It works on main for me, but doesn't work on the current branch... Especially strange if it's only reproduced for me and Steffi...

Did you run npm i on root folder? Because i set the queryParam keys in frontend buildConfig and only if you run node modules installation these new keys can be found in administration module.
Maybe thats the issue. I tested the queryParam init on all browser (chrome, firefox, safari)

seluianova · 2024-12-02T21:39:43Z

Did you run npm i on root folder?

Ah, no I haven't. I will be available tomorrow only from 2 pm, so feel free to merge if you want to deploy it earlier, I basically tested everything except that. I believe it should be good to go.

seluianova and others added 13 commits November 19, 2024 21:19

1430: Add extendable field to the card verification result

7301b8f

1430: Extend card notification

5221fd8

1430: Refactor CardQueryService

53e9c0f

1430: Adjust translations

947edf9

1430: Adjust translations and text style

323b540

1430: Use FilledButton instead of ElevatedButton

80989d2

Remove extra line break in the Koblenz publisher text

652d2dd

1430: Add elevation to the extend card notification

ceb2d57

Merge branch 'main' into 1430-extend-card

1465a24

1430: add queryParams to card extension buttons

c93164f

1430: pass each key separate to avoid linting issues, add tests, add …

5b64f2f

…workaround to fix display of more actions button

1430: fix formatting

4814e8c

f1sh1918 marked this pull request as ready for review November 27, 2024 13:18

f1sh1918 requested review from steffenkleinle, ztefanie and seluianova as code owners November 27, 2024 13:18

1430: add projectId check

21b9021

Base automatically changed from 1430-extend-card to main November 28, 2024 09:38

ztefanie reviewed Nov 28, 2024

View reviewed changes

frontend/build-configs/types.ts Outdated Show resolved Hide resolved

frontend/build-configs/constants/index.ts Show resolved Hide resolved

f1sh1918 requested a review from ztefanie December 2, 2024 10:54

steffenkleinle reviewed Dec 2, 2024

View reviewed changes

Merge branch 'main' into 1430-extend-card-add-params

3e24965

ztefanie approved these changes Dec 2, 2024

View reviewed changes

seluianova reviewed Dec 2, 2024

View reviewed changes

frontend/lib/identification/identification_page.dart Outdated Show resolved Hide resolved

steffenkleinle approved these changes Dec 2, 2024

View reviewed changes

f1sh1918 and others added 2 commits December 2, 2024 14:42

Merge branch 'main' into 1430-extend-card-add-params

fc931ee

1430: rename params, adjust getApplicationUrl function, add todo for …

5c1d8b5

…test improvements, only add queryParams if card is extendable

f1sh1918 force-pushed the 1430-extend-card-add-params branch from 30a205f to 5c1d8b5 Compare December 2, 2024 14:42

seluianova reviewed Dec 2, 2024

View reviewed changes

frontend/lib/util/get_application_url.dart Outdated Show resolved Hide resolved

seluianova reviewed Dec 2, 2024

View reviewed changes

frontend/lib/identification/identification_page.dart Outdated Show resolved Hide resolved

1430: fix minor issues

6d9a1f6

f1sh1918 merged commit 014ef5d into main Dec 2, 2024
2 checks passed

f1sh1918 deleted the 1430-extend-card-add-params branch December 2, 2024 22:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1430: Extend card add params #1803

1430: Extend card add params #1803

f1sh1918 commented Nov 27, 2024 •

edited

Loading

ztefanie left a comment

f1sh1918 commented Nov 28, 2024 •

edited

Loading

f1sh1918 commented Dec 2, 2024

steffenkleinle Dec 2, 2024

f1sh1918 Dec 2, 2024

seluianova commented Dec 2, 2024 •

edited

Loading

f1sh1918 commented Dec 2, 2024

ztefanie left a comment

steffenkleinle left a comment

seluianova commented Dec 2, 2024 •

edited

Loading

f1sh1918 commented Dec 2, 2024

seluianova commented Dec 2, 2024

1430: Extend card add params #1803

1430: Extend card add params #1803

Conversation

f1sh1918 commented Nov 27, 2024 • edited Loading

Short description

Note

Proposed changes

Side effects

Testing

Resolved issues

ztefanie left a comment

Choose a reason for hiding this comment

f1sh1918 commented Nov 28, 2024 • edited Loading

f1sh1918 commented Dec 2, 2024

steffenkleinle Dec 2, 2024

Choose a reason for hiding this comment

f1sh1918 Dec 2, 2024

Choose a reason for hiding this comment

seluianova commented Dec 2, 2024 • edited Loading

f1sh1918 commented Dec 2, 2024

ztefanie left a comment

Choose a reason for hiding this comment

steffenkleinle left a comment

Choose a reason for hiding this comment

seluianova commented Dec 2, 2024 • edited Loading

f1sh1918 commented Dec 2, 2024

seluianova commented Dec 2, 2024

f1sh1918 commented Nov 27, 2024 •

edited

Loading

f1sh1918 commented Nov 28, 2024 •

edited

Loading

seluianova commented Dec 2, 2024 •

edited

Loading

seluianova commented Dec 2, 2024 •

edited

Loading