Skip to content

Commit

Permalink
1353: upgrade flutter ci, fix deprecated methods
Browse files Browse the repository at this point in the history
  • Loading branch information
f1sh1918 committed Mar 25, 2024
1 parent afd2295 commit 03e3e34
Show file tree
Hide file tree
Showing 8 changed files with 10 additions and 20 deletions.
5 changes: 1 addition & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ commands:
steps:
- run:
command: |-
curl -o dart.deb https://storage.googleapis.com/dart-archive/channels/stable/release/3.0.5/linux_packages/dart_3.0.5-1_amd64.deb
curl -o dart.deb https://storage.googleapis.com/dart-archive/channels/stable/release/3.3.1/linux_packages/dart_3.3.1-1_amd64.deb
sudo dpkg -i dart.deb
name: Install Dart
install_dart_mac:
Expand Down Expand Up @@ -1057,9 +1057,6 @@ workflows:
when:
and:
- << pipeline.parameters.run_commit_main >>
- equal:
- main
- << pipeline.git.branch >>
deliver_beta_backend_administration:
jobs:
- bump_version:
Expand Down
2 changes: 1 addition & 1 deletion .circleci/src/commands/install_dart_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ steps:
- run:
name: Install Dart
command: |
curl -o dart.deb https://storage.googleapis.com/dart-archive/channels/stable/release/3.0.5/linux_packages/dart_3.0.5-1_amd64.deb
curl -o dart.deb https://storage.googleapis.com/dart-archive/channels/stable/release/3.3.1/linux_packages/dart_3.3.1-1_amd64.deb
sudo dpkg -i dart.deb
2 changes: 1 addition & 1 deletion .circleci/src/workflows/commit_main.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
when:
and:
- << pipeline.parameters.run_commit_main >>
- equal: [main, << pipeline.git.branch >>]
# - equal: [main, << pipeline.git.branch >>]
jobs:
- bump_version:
prepare_delivery: false
Expand Down
2 changes: 1 addition & 1 deletion frontend/.fvm/fvm_config.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"flutterSdkVersion": "3.10.2",
"flutterSdkVersion": "3.19.3",
"flavors": {}
}
13 changes: 3 additions & 10 deletions frontend/lib/home/app_flows_stack.dart
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,9 @@ class AppFlowsStack extends StatelessWidget {

@override
Widget build(BuildContext context) {
return WillPopScope(
onWillPop: () async {
final currentState = appFlows[currentIndex].navigatorKey.currentState;
final currentStatePopped = await currentState?.maybePop() ?? false;
return !currentStatePopped;
},
child: IndexedStack(
index: currentIndex,
children: _buildChildren(),
),
return IndexedStack(
index: currentIndex,
children: _buildChildren(),
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ class ActivationCodeScannerPage extends StatelessWidget {

Future<void> _onCodeScanned(BuildContext context, Uint8List code) async {
Future<void> showError(String msg, dynamic stackTrace) async =>
{await QrParsingErrorDialog.showErrorDialog(context, msg), await reportError(msg, stackTrace)};
[await QrParsingErrorDialog.showErrorDialog(context, msg), await reportError(msg, stackTrace)];

try {
final activationCode = const ActivationCodeParser().parseQrCodeContent(code);
Expand Down
2 changes: 1 addition & 1 deletion frontend/lib/identification/id_card/id_card.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class IdCard extends StatelessWidget {
aspectRatio: creditCardAspectRatio,
child: MediaQuery(
// Ignore text scale factor to enforce the same layout on all devices.
data: mediaQueryData.copyWith(textScaleFactor: 1),
data: mediaQueryData.copyWith(textScaler: TextScaler.linear(1)),
child: CardContent(cardInfo: cardInfo, region: region, isExpired: isExpired, isNotYetValid: isNotYetValid),
),
),
Expand Down
2 changes: 1 addition & 1 deletion frontend/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ dependencies:
flutter_svg: ^2.0.2
permission_handler: ^11.3.0
package_info_plus: ^4.0.1 # for about dialog
mobile_scanner: ^4.0.1 # Pinning this version because of https://github.com/juliansteenbakker/mobile_scanner/issues/582
mobile_scanner: ^4.0.1
fixnum: ^1.1.0
flutter_secure_storage: ^9.0.0
infinite_scroll_pagination: ^4.0.0
Expand Down

0 comments on commit 03e3e34

Please sign in to comment.