Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/image upload #3963

Merged
merged 28 commits into from
Oct 2, 2024
Merged

feature/image upload #3963

merged 28 commits into from
Oct 2, 2024

Conversation

Chrysalis-B
Copy link
Contributor

  • feature(wip): add file upload feature to editor
  • feature: render e:image tags from xml in prosemirror editor as img and revert them back to e:image when passed back

@Chrysalis-B Chrysalis-B force-pushed the feature/image-upload branch 7 times, most recently from f1c446e to 17f58ae Compare September 24, 2024 13:53
Chrysalis-B
Chrysalis-B commented Sep 25, 2024
View reviewed changes
Copy link
Contributor Author

@Chrysalis-B Chrysalis-B left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tarkista että onContentChange triggeröityy heti

@Chrysalis-B
Copy link
Contributor Author

tarkista että onContentChange triggeröityy heti

kyllä triggeröityy.

@Chrysalis-B
feature(wip): add file upload feature to editor
6440b20
@Chrysalis-B
feature: render e:image tags from xml in prosemirror editor as img an…
c4a5d07 
…d revert them back to e:image when passed back
@Chrysalis-B
refactor: add custom class already in exam mastering as opposed to pr…
8abe98d 
…osemirror parsing function
@Chrysalis-B
refactor(wip): alternative way to add custom classes to images
bbdd3d5
@Chrysalis-B
refactor: use data-attributes instead of classed for editor element m…
c06f818 
…atching
@Chrysalis-B
refactor: use seperate schemas for editor input and output instead of…
d5b5b86 
… custom serializer
@Chrysalis-B
fix: only export attributes that conform to xml schema
4b3756d
@Chrysalis-B
feature(wip): send file as buffer to saveScreenshot callback for furt…
b976660 
…her processing
@Chrysalis-B
feature: update image with permanent url
31c9296
@Chrysalis-B
test(wip): start adding unit tests for image upload
402e7af
@Chrysalis-B
chore: update snapshots
9844198
@Chrysalis-B
refactor/test: make insertTest util for all tests and get rid of prom…
de14074 
…isified fireEvents (use findByText in act instead which returns a promise)
@Chrysalis-B Chrysalis-B marked this pull request as ready for review September 30, 2024 11:33
Chrysalis-B
Chrysalis-B commented Oct 2, 2024
View reviewed changes
packages/core/src/components/grading-instructions/editor/ImageUploadButton.tsx Outdated
<button onClick={handleButtonClick}>Lisää kuva</button>
<input
type="file"
accept="image/*"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vain jpeg, png ja tiff

@Chrysalis-B Chrysalis-B merged commit 0ed943f into feature/editable-grading-instructions Oct 2, 2024
3 checks passed
@Chrysalis-B Chrysalis-B deleted the feature/image-upload branch October 2, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Chrysalis-B