Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove user_config.py #303

Merged
merged 3 commits into from
Dec 31, 2024
Merged

fix: remove user_config.py #303

merged 3 commits into from
Dec 31, 2024

Conversation

yucongalicechen
Copy link
Contributor

I don't think this is used anywhere, so I deleted it
@sbillinge ready for review

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88d8d73) to head (59c8ecb).
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #303   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         9    +1     
  Lines          500       516   +16     
=========================================
+ Hits           500       516   +16     

see 2 files with indirect coverage changes

Copy link
Contributor

@sbillinge sbillinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

which functions are doing these tasks?


**Removed:**

* `user_config.py` function.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is written for changelog.rst, both used by savvy users and future maintainers (could be new members) maybe a bit more context would be better as to what was changed (user config.py) which is stated and also maybe why this was removed?

@yucongalicechen
Copy link
Contributor Author

which functions are doing these tasks?

_load_config and check_and_build_global_config in tools.

@yucongalicechen
Copy link
Contributor Author

@sbillinge ready for review. I clarified in the news.

@sbillinge
Copy link
Contributor

actually, I think we should keep this and use it. In principle, we can allow users to override the name and path of the config file this way.

@sbillinge
Copy link
Contributor

I took a look at this, and I think it doesn't add much. I will merge this and we can get rid of it. The other functions can be easily extended if we want to allow users to override the paths or filenames.

@sbillinge sbillinge merged commit c8d6775 into diffpy:main Dec 31, 2024
5 checks passed
@yucongalicechen yucongalicechen deleted the check branch December 31, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants