-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove user_config.py #303
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 500 516 +16
=========================================
+ Hits 500 516 +16 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which functions are doing these tasks?
news/remove-userconfig.rst
Outdated
|
||
**Removed:** | ||
|
||
* `user_config.py` function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is written for changelog.rst, both used by savvy users and future maintainers (could be new members) maybe a bit more context would be better as to what was changed (user config.py) which is stated and also maybe why this was removed?
|
@sbillinge ready for review. I clarified in the news. |
actually, I think we should keep this and use it. In principle, we can allow users to override the name and path of the config file this way. |
I took a look at this, and I think it doesn't add much. I will merge this and we can get rid of it. The other functions can be easily extended if we want to allow users to override the paths or filenames. |
I don't think this is used anywhere, so I deleted it
@sbillinge ready for review