refactor: separate isfloat into a new file within validators.py and rename to is_number
#301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobleesj
commented
Dec 31, 2024
There was a problem hiding this comment.
I reran auto_api just to ensure the new api is loading since we've created a new file src/diffpy/utils/validators.py
bobleesj
commented
Dec 31, 2024
| @@ -17,6 +17,8 @@ | |||
|
|
|||
| import numpy | |||
|
|
|||
| from diffpy.utils import validators | |||
There was a problem hiding this comment.
import is_number from validators
bobleesj
commented
Dec 31, 2024
tests/test_validators.py
Outdated
| from diffpy.utils.validators import is_number | ||
| import pytest | ||
|
|
||
| @pytest.mark.parametrize("input,expected", [ |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #301 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 9 +1
Lines 511 516 +5
=========================================
+ Hits 511 516 +5
|
bobleesj
changed the title
isfloat into a separate file within validators.py and rename to is_numberisfloat into a new file within validators.py and rename to is_number
|
@sbillinge ready for review - seems like we are all done with 3.6.0 issues on time! Dec 30th. I also spoke to Lucas as well. Once merged, I will use this PR as an educational material. |
|
very beautiful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7