-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
factor out isfloat to a separate file #7
Comments
Could use isfloat from fastnumbers, compatible with 3.7+ (including 3.11). Maybe good to create a new module |
I guess btw, why does it have to be a float? is an integer not ok? Python automatically treats integers as floats if they are composed int a math expression with other floats. What is the reason it has to be a float and not a number (more general)? |
The times isfloat is used is when checking whe a nonnumerical data type (like string) may encode a float. It can be given a more generic name like isnumber. |
@lucas-lemos-da-silva has volunteered to resolve this issue. if you have any questions regarding this issue, please feel free to tag @sbillinge or @bobleesj here. |
Lucas, please let us know today or tmr - if this issue is a bit challenging, I can resolve this issue since 3.6.0 is pending soon |
Perhaps to diffpy.utils.typecheck module?
The text was updated successfully, but these errors were encountered: