Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve comments for @pytest.mark.parametrize test cases in test_scale_to function #274

Closed
bobleesj opened this issue Dec 23, 2024 · 1 comment · Fixed by #280
Closed

Improve comments for @pytest.mark.parametrize test cases in test_scale_to function #274

bobleesj opened this issue Dec 23, 2024 · 1 comment · Fixed by #280
Assignees
@yucongalicechen
Milestone
3.6.0 release

Comments

@bobleesj
Copy link
Contributor 

          @sbillinge ready for review.

@yucongalicechen , the part that is remaining is the test_scale_to function.

The existing comments like# C2: Same length x-arrays with exact x-value match, # C3: Same length x-arrays with approximate x-value match were abit hard for me to understand what's being tested. Would you mind improving this test comments for test_scale_to using the above format?

Originally posted by @bobleesj in #273 (comment)
@bobleesj bobleesj changed the title Improve @pytest.mark.parametrize test cases in test_scale_to function Improve comments for @pytest.mark.parametrize test cases in test_scale_to function Dec 23, 2024
@bobleesj bobleesj added this to the 3.6.0 release milestone Dec 23, 2024
@yucongalicechen
Copy link
Contributor

I can take this issue!

@yucongalicechen yucongalicechen mentioned this issue Dec 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yucongalicechen yucongalicechen

Labels
None yet
Projects
None yet
Milestone
3.6.0 release
Development

Successfully merging a pull request may close this issue.

improve comments for test_scale_to yucongalicechen/diffpy.utils
2 participants
@bobleesj @yucongalicechen